Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support utf-8 encoded comment field #177

Open
mayswind opened this issue Dec 3, 2023 · 2 comments
Open

Support utf-8 encoded comment field #177

mayswind opened this issue Dec 3, 2023 · 2 comments

Comments

@mayswind
Copy link

mayswind commented Dec 3, 2023

What version of this package are you using?
11.0.14

What problem do you want to solve?
Comment field in torrent files which generated in old application would not use utf-8 as default character encoding, and there files also have an extra utf-8 encoded field, like comment.utf-8. The comment field in these torrent files would have garbled characters by using parse-torrent (see the below screenshot).

image

What do you think is the correct solution to this problem?
Parse the comment content from the utf-8 encoding field first, like processing the name field.

Are you willing to submit a pull request to implement this change?
Yes

@ThaUnknown
Copy link
Member

where did this happen in real-world cases?

@mayswind
Copy link
Author

mayswind commented Dec 3, 2023

where did this happen in real-world cases?

Actually, I opened some old torrent files and found this problem. I think it's not a good idea to put those torrents here directly, so I made the a testcase file and put it to #178.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants