Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for download selected files only #265

Closed
wants to merge 1 commit into from
Closed

fix for download selected files only #265

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2022

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
This is a temporary fix for the open issue webtorrent/webtorrent#164 to make webtorrent-cli work as expected until the webtorrent team improves the API. It implements fix webtorrent/webtorrent#164 (comment), which is also referenced in the official webtorrent documentation as relevant (https://github.com/webtorrent/webtorrent/blob/master/docs/api.md#filedeselectpriority), so I decided to create a pull request with that fix.

Which issue (if any) does this pull request address?
argv.select has no effect and webtorrent-cli downloads the whole torrent instead, even while streaming. Users report this is an unwanted use of resources:

#222
#250

Is there anything you'd like reviewers to focus on?

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Feb 27, 2023
@github-actions github-actions bot closed this Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

file.deselect supposedly not working
0 participants