Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to select the front cover as the poster for audio/music torrents #1332

Closed
Borewit opened this issue Mar 4, 2018 · 2 comments
Closed

Comments

@Borewit
Copy link
Member

Borewit commented Mar 4, 2018

Improve the poster selection for audio/music based torrent, aiming to get the cover-art selected as the torrent poster.

The poster selection function has an existing ToDo, indicating some more work needs to be done for audio based torrents:

// TODO: generate a waveform from the largest sound file

Downloading the torrent from the audio album: Parov Stellar - The Princess currently results in the following:
parovprincess weird poster without music-metadata

@Borewit
Copy link
Member Author

Borewit commented Mar 4, 2018

It does now select the correct poster in the index:
parovprincess index with poster

Playing the same track with this merge:
parov steller - milla s dream - with poster

Putting the music-metadata merge (#1240) on top of that would give:
parov steller - milla s dream - with poster and music-metadata merge

@codealchemist
Copy link
Contributor

Closing after #1334.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants