Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External player can not be changed from VLC. (Windows and Linux.) #1402

Closed
ghost opened this issue May 20, 2018 · 4 comments
Closed

External player can not be changed from VLC. (Windows and Linux.) #1402

ghost opened this issue May 20, 2018 · 4 comments
Labels

Comments

@ghost
Copy link

ghost commented May 20, 2018

What version of WebTorrent Desktop?
Version 0.20.0 (0.99.3) (64-bit) on Fedora and Version 0.20.0 (0.98.21) (64-bit) on Windows..
What operating system and version?
Fedora 28 (GNOME) and Windows 10 1803
What did you do?
Attempted to change external player through the GUI menu option and then (when unsuccessful) by config file.
What did you expect to happen?
New videos to open in chosen media player.
What actually happened?
No change to the external player. Continues to say "VLC".

@feross
Copy link
Member

feross commented May 20, 2018

Can you try to reproduce this issue once more? But this time when it happens, click View > Developer > Developer Tools, select the Console tab and copy-paste all the text into a new comment here.

If you don't see any errors, then please check in one more place! Click View > Developer > Show WebTorrent Process, select the Console tab and copy-paste all the text.

Being able to see that output would help us out very much. Thanks.

@ghost
Copy link
Author

ghost commented May 21, 2018

It looks like it does change in Windows, nothing changes at first (still says "VLC" with no path) but if you close and reopen it it will have the path of the new player, and works as expected. I don't have access to my Fedora machine at the moment, will update soon. Thanks fort the reply.

@feross
Copy link
Member

feross commented May 22, 2018

It seems like we have a state bug where the UI isn't reflecting the internal state correctly.

@feross feross added the bug label May 22, 2018
@mathiasvr
Copy link
Contributor

This should be fixed by #1042.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants