Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move player to separate window #5

Closed
ungoldman opened this issue Mar 4, 2016 · 2 comments
Closed

move player to separate window #5

ungoldman opened this issue Mar 4, 2016 · 2 comments

Comments

@ungoldman
Copy link
Contributor

I think it would be beneficial to move the video player to a separate window so that a user can see everything in the list and have one or more video players open simultaneously. This would simplify managing state for the list window too.

If you think it's worth doing, I can take a crack at it.

@ChrisMorrisOrg
Copy link
Contributor

I would like to be able to see my list of torrents while streaming a video too. Not really sure if this is preferable in terms of UX and code maintenance, but what if the user can open a video in a new window when they double-click on a torrent, but keep it within the window if they single-click the play button? Might add unnecessary complexity that way, though. The only reason I throw that idea out there is because I like to try keeping things in a single window unless I really need to open another one.

If I had to choose one or the other, I'd prefer videos to open in a new window. Functionality > form.

@feross
Copy link
Member

feross commented Mar 20, 2016

I think we should come back to this idea for WebTorrent v2. Right now I want to get something shipped ASAP and I like the idea of keeping v1 really simple so we can focus on making it rock solid and reliable.

@feross feross closed this as completed Mar 20, 2016
@lock lock bot locked as resolved and limited conversation to collaborators May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants