Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove torrent immediately, but allow Undo #970

Open
DiegoRBaquero opened this issue Sep 26, 2016 · 7 comments
Open

Remove torrent immediately, but allow Undo #970

DiegoRBaquero opened this issue Sep 26, 2016 · 7 comments

Comments

@DiegoRBaquero
Copy link
Member

I'd like to make a feature request.

If you are removing many torrents from the client you have to click on the remove button in the confirmation dialog each time. It would be great if I could check a checkbox that said "Do not show this again" and just click on the X that removes the torrents.

What do you guys think?

@mathiasvr
Copy link
Contributor

I actually included such a checkbox in my initial PR for the confirmation modals, but it seemed more clean not to have it. Another way to solve this is by having a preference as suggested in #853.

@feross
Copy link
Member

feross commented Sep 27, 2016

The cleanest way to solve this, IMO, is to just remove it immediately, but to show a little "Undo" hover card at the bottom of the view for 10 seconds after deleting a torrent.

The thinking is: Do what the user wants immediately. Treat the user like an adult who knows what they're doing, so don't ask for confirmation constantly. Yet, provide a means for them to recover from mistakes.

Here's an example of how Inbox (by Google) implements this, in the bottom-left corner of the app.

screen shot 2016-09-26 at 11 19 26 pm

@DiegoRBaquero
Copy link
Member Author

@feross Damn, I love that idea. Would definitely leave preferences to be important stuff and never bother the user.

@feross
Copy link
Member

feross commented Sep 27, 2016

@DiegoRBaquero Yeah, some things need preferences, but I think the right instinct is to push back and consider other solutions first. Once you add a preference it's really hard to remove. Let's try really hard to do the right thing, and use preferences as a last resort. 👍

@mathiasvr
Copy link
Contributor

@feross I like this idea, but I wonder if it would be enough to just use undo/cmd+z then?

@feross
Copy link
Member

feross commented Sep 27, 2016

Hm, I think that a keyboard shortcut alone works as a first attempt. But I would want to play around with the little notification message at the bottom and see if that's helpful to the user. Maybe it's too much for a desktop app, but we should try it IMO.

Btw, for the "delete file data" option in the right click menu, we probably still want the confirmation dialog since that's not possible to reverse, and it's a less commonly used than just clicking the 'X'.

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Oct 16, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 23, 2022
@alxhotel alxhotel reopened this Oct 23, 2022
@alxhotel alxhotel added accepted and removed stale labels Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants