Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDrop Node 8 support #1681
Closed
Drop Node 8 support #1681
Labels
Comments
This comment has been minimized.
This comment has been minimized.
|
0.106.0 is released, without Node 8 support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Node 8 is EOL on December 31 (in 5 months from now). This date is earlier than the usual date in April. I believe a special exception was made to EOL Node 8 a bit earlier than normal, just for this version.
If we drop support for Node 8 then we can remove some unneeded dependencies and some hacks in the codebase. I'd like to do that. Folks who need Node 8 can pin their
webtorrentversion inpackage.json.This is part of my overall effort to update and clean up
webtorrentdependencies: brave/brave-browser#5490Some things to do:
mkdirpand replace withfs.mkdir(path[, options], callback)with the{ recursive: true }option.require('url')(even for fallback) and replace withURLeverywhere