Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximised Window - Top/Bottom Edge + Corners Cannot Resize #42

Closed
ChrisMorrisOrg opened this issue Mar 16, 2014 · 3 comments
Closed

Maximised Window - Top/Bottom Edge + Corners Cannot Resize #42

ChrisMorrisOrg opened this issue Mar 16, 2014 · 3 comments

Comments

@ChrisMorrisOrg
Copy link

I've only tested this on Mac OS - this may not occur in Windows. I suspect the window is just flowing slightly off the screen or perhaps the "hit area" around the border of the window is too small. Essentially, if you maximise WebTorrent, you can only resize the window using the left and right sides of the frame. You must move the window in order to resize from the top, bottom, or any of the four corners.
@feross
Copy link
Member

feross commented Mar 20, 2014

Yeah, noticed this. It's an issue with chrome apps on OS X. I think not using the chromeless UI that I'm using to get the realistic OS X would make this issue go away.

@ChrisMorrisOrg
Copy link
Author

Ah right, that's a bummer!

@feross
Copy link
Member

feross commented Mar 20, 2014

Hoping that node-webkit handles this better. I think that's a better direction moving forward.

@feross feross closed this as completed Apr 19, 2014
@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
Jon-Biz pushed a commit to Jon-Biz/webtorrent that referenced this issue Oct 19, 2020
@feross
Recover from unexpected events better
026f2c2 
When you restart the tracker server, all peers it's tracking are
discarded. Then, clients that are already running will continue to send
`update` events, but the tracker throws them away because it was
expected to get a `start` event first.

This should only be a warning, and not a fatal error. I just made the
following changes:

- unexpected `started` event (for peer already in swarm) is treated as
an `update`
- unexpected `stopped` event is discarded
- unexpected `completed` event is treated as a `start`
- unexpected `update` event (from peer not in swarm) is treated as
`start`

Fixes webtorrent#42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feross @ChrisMorrisOrg