Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize seeding #1398

Merged
merged 2 commits into from
Nov 28, 2018
Merged

Optimize seeding #1398

merged 2 commits into from
Nov 28, 2018

Conversation

KayleePop
Copy link
Contributor

@KayleePop KayleePop commented May 18, 2018 •
edited

  • Stop verifying the hashes of files passed into client.seed() (we just calculated the hashes that are being checked)
  • Don't call torrent.load() when seeding an FS filepath. (fs-chunk-store is initialized using the same paths, so the files already exist in the store)

Fixes #524 and fixes #1237

@KayleePop KayleePop changed the title Optimize file seeding Optimize seeding May 18, 2018
@feross
Copy link
Member

feross commented May 20, 2018

Thanks for the PR. I'll review it as soon as I get the chance. In the meantime, reviews from other collaborators are welcome and appreciated.

@DiegoRBaquero
Copy link
Member

Hey @KayleePop , willing to update to the new code base? taking into account that
#1434 was merged

@KayleePop
Copy link
Contributor Author

Rebased

@stale
Copy link

stale bot commented Nov 27, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Nov 27, 2018
@stale stale bot removed the stale label Nov 28, 2018
@DiegoRBaquero DiegoRBaquero merged commit c32790d into webtorrent:master Nov 28, 2018
@KayleePop KayleePop deleted the seed-verify branch November 29, 2018 00:32
@lock lock bot locked as resolved and limited conversation to collaborators Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DiegoRBaquero DiegoRBaquero DiegoRBaquero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should local file seeds pieces be verified Seeding re-stores chunks even if they are already stored
3 participants
@KayleePop @feross @DiegoRBaquero