Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upability to close and restore streaming server #1547
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
request-info
bot
commented
Nov 22, 2018
|
|
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Nov 22, 2018
|
|
This comment has been minimized.
This comment has been minimized.
stale
bot
commented
Apr 7, 2019
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
lib/server.js
Outdated
| closed = false | ||
| server.on('connection', onConnection) | ||
| server.on('request', onRequest) | ||
| _listen.call(server, port) |
This comment has been minimized.
This comment has been minimized.
alxhotel
Apr 7, 2019
•
Member
In order to make this compatible and pass the tests, it should be changed to:
server.listen = (...args) => {
...
_listen.apply(server, args)
}| @@ -25,7 +30,6 @@ function Server (torrent, opts = {}) { | |||
| const onReady = pendingReady.pop() | |||
| torrent.removeListener('ready', onReady) | |||
| } | |||
| torrent = null | |||
This comment has been minimized.
This comment has been minimized.
untitledlt
force-pushed the
untitledlt:close-restore
branch
2 times, most recently
from
8f5ade2
to
9f69f97
This comment has been minimized.
This comment has been minimized.
|
@alxhotel please see updated PR |
This comment has been minimized.
This comment has been minimized.
|
@alxhotel @DiegoRBaquero any chance to get this merged any time soon? |
This comment has been minimized.
This comment has been minimized.
welcome
bot
commented
Jun 11, 2019
|
|
This comment has been minimized.
This comment has been minimized.
|
Do you need this published to npm? |
This comment has been minimized.
This comment has been minimized.
|
Sure. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
untitledlt commentedNov 22, 2018
•
edited
Added ability to restore steaming server by calling
.listen(port)on existing server which was closed before with.close()registered issue: #1545