ability to close and restore streaming server #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 We would appreciate it if you could provide us with more information about this issue. |
|
🙌 Thanks for opening this pull request! You're awesome. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
alxhotel
requested changes
Apr 7, 2019
lib/server.js
Outdated
| closed = false | ||
| server.on('connection', onConnection) | ||
| server.on('request', onRequest) | ||
| _listen.call(server, port) |
There was a problem hiding this comment.
In order to make this compatible and pass the tests, it should be changed to:
server.listen = (...args) => {
...
_listen.apply(server, args)
}| @@ -25,7 +30,6 @@ function Server (torrent, opts = {}) { | |||
| const onReady = pendingReady.pop() | |||
| torrent.removeListener('ready', onReady) | |||
| } | |||
| torrent = null | |||
There was a problem hiding this comment.
Move torrent = null inside server.destroy(cb).
|
@alxhotel please see updated PR |
alxhotel
approved these changes
May 21, 2019
DiegoRBaquero
approved these changes
May 22, 2019
|
@alxhotel @DiegoRBaquero any chance to get this merged any time soon? |
|
🎉 Congrats on getting your first pull request landed! |
|
Do you need this published to npm? |
|
Sure. Thanks! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to restore steaming server by calling
.listen(port)on existing server which was closed before with.close()registered issue: #1545