fix: malformed debug ID #2733
Merged
fix: malformed debug ID #2733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can see debug messages from WebTorrent with the `DEBUG` environment
variable. For example, in this repository:
DEBUG=webtorrent npm test
Debug messages should contain the first 7 characters of the peer ID.
However, they currently look like this:
webtorrent [02undef] listening +7ms
"02undef" seems wrong. After this change, the debug ID looks correct:
webtorrent [2d57573] listening +7ms
This happened because `peerId` is a string but was mistakenly being
treated like a buffer.
|
🙌 Thanks for opening this pull request! You're awesome. |
|
right, in v1 this did |
ThaUnknown
approved these changes
Jan 12, 2024
|
🎉 Congrats on getting your first pull request landed! |
webtorrent-bot
pushed a commit
that referenced
this pull request
Jan 12, 2024
## [2.1.33](v2.1.32...v2.1.33) (2024-01-12) ### Bug Fixes * malformed debug ID ([#2733](#2733)) ([2453316](2453316))
|
🎉 This PR is included in version 2.1.33 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
You can see debug messages from WebTorrent with the
DEBUGenvironment variable. For example, in this repository:DEBUG=webtorrent npm testDebug messages should contain the first 7 characters of the peer ID. However, they currently look like this:
"02undef" seems wrong. After this change, the debug ID looks correct:
This happened because
peerIdis a string but was mistakenly being treated like a buffer.Which issue (if any) does this pull request address?
No GitHub issues I'm aware of.
Is there anything you'd like reviewers to focus on?
No.