Working commandline downloads and removing unused code #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #28 |
| // TODO | ||
| client.on('torrent', function (torrent) { | ||
| client.on('error', function (err) { | ||
| clivas.line('{red:error} ' + err) |
There was a problem hiding this comment.
i think this should have been err.message
|
Thanks for the PR -- I appreciate you helping to push this project forward! I would have left in the http range server stuff because we should support that asap. But we can just re-add it when it's fully functional. Also, if it's easy for you, set your editor to trim trailing whitespace on save. :) You should come hang out on IRC. #webtorrent on freenode. We can coordinate easier there. |
|
Okay; I setup my env to trim trailing whitespace from now on. Sorry about that. Will definitely look for you on IRC :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all unused code; some of which now resides in bittorrent-client and some of which was for the http version of the interface and should be readded only once its functional.
Also cleaned up logging (spread across PRs for bittorrent-swarm and bittorrent-client) and got the peerflix-based commandline working. Downloading a single torrent from the commandline now provides a nice chalk-based interface which is handy for telling what's actually going on under the hood.