fix: Use new prototypes for objc_msgSend #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great catch @rajivshah3 - but we need to verify that its really working equivalently. Anyone care to test this on MacOS? |
|
I can take some time test this tonight. Might also test if we can increase the readability a bit. |
|
LGTM. I tested some macro on it but they become worse. Guess it's better to leave as is. |
wusyong
approved these changes
Jul 24, 2020
|
New macbook seems to enable "Strict Checking of objc_msgSend Calls" by default. |
SteffenL
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
objc_msgSendwithOBJC_OLD_DISPATCH_PROTOTYPESis dangerous. The new prototypes were introduced specifically to prevent odd behavior that may occur as a result of how variadic parameters are handled (see this article). This PR updates each call toobjc_msgSendso that it is casted appropriately for the corresponding Objective-C call.