Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ephemeral peer channels #59

Merged
merged 5 commits into from
Jun 4, 2024
Merged

feat: ephemeral peer channels #59

merged 5 commits into from
Jun 4, 2024

Conversation

Septias
Copy link
Contributor

@Septias Septias commented Apr 3, 2024

Part of 5346

@Septias Septias changed the title fead: ephemeral peer channels feat: ephemeral peer channels Apr 8, 2024
Copy link
Contributor

@hpk42 hpk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good -- so this allows to let the hello example use realtime channels?

@Simon-Laux Simon-Laux requested a review from r10s May 12, 2024 19:07
@Septias
Copy link
Contributor Author

Septias commented May 13, 2024

It just adds the api - not using it. But since Hello is the entry point for webxdc development I suppose this should be here @hpk42

@hpk42
Copy link
Contributor

hpk42 commented May 14, 2024 via email

@Septias
Copy link
Contributor Author

Septias commented May 14, 2024

Yes that works for multiple tabs. Wanted to cross this off my mental list, but we can also keep it open until realtime API actually arrived on the platforms

Copy link
Contributor

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not test

@Septias Septias merged commit d648feb into master Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants