joinRealtimeChannel method with webxdc realtime API
#78
Conversation
hpk42
changed the title
joinRealtimeSession method for managing realtime sessionsjoinRealtimeSession method for managing realtime sessions
hpk42
changed the title
joinRealtimeSession method for managing realtime sessionsjoinRealtimeChannel method for managing realtime sessions
hpk42
changed the title
joinRealtimeChannel method for managing realtime sessionsjoinRealtimeChannel method with webxdc realtime API
src-docs/spec/joinRealtimeSession.md
Outdated
|
|
||
| Start listening on the realtime channel using the specified callback. | ||
| The callback receives `Uint8Array` data items that were sent from connected peers. | ||
| Calling `setListener` a second time will replace the previous listener. |
There was a problem hiding this comment.
what happens if the passed value is something other than a function? for instance:
realtimeChannel.setListener()Will that throw an error, or cause it to stop listening?
There was a problem hiding this comment.
i guess it should throw an error -- Also "send()" should throw an error if not argument is provided. FWIW in Python the interpreter would do it itself and there is no need to specify that extra. Maybe we can get to make it a general practise in webxdc APIs to throw errors when the minimally specified arguments are not passed in, also for setUpdateListener etc.
src-docs/spec/joinRealtimeSession.md
Outdated
| connected peers but not by peers connecting later. | ||
|
|
||
| Calling `joinRealtimeChannel` a second time without leaving the prior one | ||
| will not cause any action and returns a `null` value. |
There was a problem hiding this comment.
Maybe better not specify it? Something happens, maybe null, maybe an exception.
There was a problem hiding this comment.
hum, I prefer APIs that have defined results so that i don't need to check for any of undefined, null or exception to notice errors.
Co-authored-by: link2xt <link2xt@testrun.org>
|
Should we merge this @hpk42 I think it is stable now |
alternative to #77 implementing all realtime functiuonality through a single
joinRealtimeChannelobject.