-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resizable windows #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you prepare a version of this PR without the pnpm lock file? I'd prefer to stick to npm for development for the time being and I don't see a compelling reason to switch.
pnpm is like the newer more coolish version of npm. Since it utilizes package cashing it is more efficient for multi project work. We can still use npm though as it serves the exact same purpose as npm in everyday use. |
This reverts commit 51a4f01.
How is it looking @faassen ? Should I just merge this or do you still want to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice that we can resize the sidebar, but:
-
I can't collapse the sidebar anymore to make it go away entirely. Some people really don't care about the messages in it, and allowing it to collapse conveniently supported their use case.
-
There is no indication anywhere I can resize the sidebar except a very subtle mouseover; no resize button I can use to drag
-
the README still mentions you can collapse with the arrow so is out of date.
There is no indicator I can resize the sidebar. I think the docs in the README also still mention the expand/contract option.
@faassen can you review the prs? |
fixes #25
TODO