Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizable windows #28

Merged
merged 9 commits into from
Sep 30, 2022
Merged

Resizable windows #28

merged 9 commits into from
Sep 30, 2022

Conversation

Septias
Copy link
Contributor

@Septias Septias commented Aug 19, 2022

  • Some small styling changes
  • Add a way to resize left and right panel to give more space to logs or devices

image

fixes #25

TODO

  • Make sidebare 100% collapseable
  • update Readme.md
  • Rewrite resize component to use SolidJs

@Septias Septias changed the title [wip] Resizable windows Resizable windows Aug 21, 2022
@Septias Septias requested a review from faassen August 21, 2022 14:38
Copy link
Collaborator

@faassen faassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you prepare a version of this PR without the pnpm lock file? I'd prefer to stick to npm for development for the time being and I don't see a compelling reason to switch.

@Septias
Copy link
Contributor Author

Septias commented Aug 24, 2022

pnpm is like the newer more coolish version of npm. Since it utilizes package cashing it is more efficient for multi project work. We can still use npm though as it serves the exact same purpose as npm in everyday use.

@Septias Septias requested a review from faassen August 24, 2022 08:45
@Septias
Copy link
Contributor Author

Septias commented Aug 29, 2022

How is it looking @faassen ? Should I just merge this or do you still want to review?

frontend/Chat.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@faassen faassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice that we can resize the sidebar, but:

  • I can't collapse the sidebar anymore to make it go away entirely. Some people really don't care about the messages in it, and allowing it to collapse conveniently supported their use case.

  • There is no indication anywhere I can resize the sidebar except a very subtle mouseover; no resize button I can use to drag

  • the README still mentions you can collapse with the arrow so is out of date.

There is no indicator I can resize the sidebar. I think the docs in the README also still mention the expand/contract option.

frontend/SplitView.tsx Outdated Show resolved Hide resolved
@Septias Septias changed the title Resizable windows [wip] Resizable windows Sep 6, 2022
@Septias Septias changed the title [wip] Resizable windows Resizable windows Sep 8, 2022
@Septias Septias requested a review from faassen September 8, 2022 16:24
@Septias
Copy link
Contributor Author

Septias commented Sep 11, 2022

@faassen can you review the prs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Devices flickering
2 participants