-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete devices #29
Delete devices #29
Conversation
Hey @faassen are you still actively developing this project? I've seen there has been no activity on my other pr as well for a long time. If you however find the time maybe you can look into this because I know too little about websockets & express and how to idiomatically shut down a ws-instance. |
I'm not very actively working on this right now, but if you ping me here or on deltachat to remind me I can take a look once every while. Concerning deleting devices: I'd be interested in hearing more about the use cases surrounding this - I guess it simulates a group member being removed from a group? Because intermittent connections can already be handled by disconnecting. As a general comment, I left some comments on your code. I am still trying to understand the behavior you describe. |
Oh, another small note, in your codebase "delete" comes before "add" in |
As I mentioned, using I don't really know how to close an express server either so I googled and found this: expressjs/express#1366 (comment) So if in Maybe that helps! |
Thank you for this very quick response and I'm sorry you had to make so many simple corrections. This PR isn't really ready for review yet, I just pinged you because I wanted to know how to correctly shutdown ws instances. |
Regarding the usecase of this, I took it out of the todos when I was looking for stuff that could be done. |
I've looked into the disconnect behaviour and deleting a device is essentially a disconnect which is already covered by tests. In the end deleting a device is just a glorified disconnect so I did not add more tests |
This pr adds a delete button to each device so devices no longer used can be trashed