Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the backend Context ref in Element for earlier backend release #121

Closed
LastLeaf opened this issue Dec 22, 2023 · 0 comments
Closed

Remove the backend Context ref in Element for earlier backend release #121

LastLeaf opened this issue Dec 22, 2023 · 0 comments
Assignees
@LastLeaf
Labels
enhancement New feature or request module:core

Comments

@LastLeaf
Copy link
Member

Some backends ref-counts the Context to free the context-related resources. Consider release all refs of Context after root detached.

Furthermore, ShadowRoot.create* calls should return null backend element after detached.
@LastLeaf LastLeaf added enhancement New feature or request module:core labels Dec 22, 2023
@LastLeaf LastLeaf self-assigned this Dec 22, 2023
LastLeaf added a commit that referenced this issue Jan 8, 2024
@LastLeaf
feat: drop context on element destroy (#121)
6344604
LastLeaf added a commit that referenced this issue Jan 8, 2024
@LastLeaf
fix(miniprogram-adapter): match new core api (#121)
90a3720
LastLeaf added a commit that referenced this issue Jan 8, 2024
@LastLeaf
Merge pull request #124 from wechat-miniprogram/feat-drop-context-on-…
9802148 
…element-destroy

feat: drop context on element destroy (#121)
@LastLeaf LastLeaf closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LastLeaf LastLeaf

Labels
enhancement New feature or request module:core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LastLeaf