Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When comparer is set and returns true, the property will still not be updated if the value equals to the old one #57

Closed
LastLeaf opened this issue Jun 27, 2023 · 2 comments
Assignees
Labels
bug Something isn't working module:core
Milestone

Comments

@LastLeaf
Copy link
Member

When comparer is set and returns true, the property value comparison is still executed:

if (!excluded && oldData !== filteredData) {

Is it expected?

@LastLeaf LastLeaf self-assigned this Sep 4, 2023
@LastLeaf LastLeaf added bug Something isn't working module:core labels Sep 4, 2023
@LastLeaf LastLeaf added this to the v0.2 milestone Sep 4, 2023
@LastLeaf
Copy link
Member Author

LastLeaf commented Sep 8, 2023

comparer should refers to "does this change require template updates?"

It should triggers after the data observer (if any), since data observers always trigger no matter data changed or not.

@LastLeaf
Copy link
Member Author

LastLeaf commented Sep 8, 2023

Consider allow comparer in common data fields in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module:core
Projects
None yet
Development

No branches or pull requests

1 participant