Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always call createComponent from wrapper createCommonElement #106

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Always call createComponent from wrapper createCommonElement #106

merged 3 commits into from
Oct 30, 2023

Conversation

SgLy
Copy link
Contributor

@SgLy SgLy commented Oct 26, 2023 •
edited
Loading

  1. remove placeholding judgement from wrapper, since logics in createComponent is quite the same as checkComponentPlaceholder
  2. always call createComponent (but not createComponentOrNativeNode) from wrapper createCommonElement as a result of 1
  3. rename placeholderHandler in Element to placeholderHandlerRemover, to improve readability
  4. add allowUnusedNativeNode option to ComponentSpace, to allow unused tag name created as a NativeNode

@SgLy SgLy requested review from LastLeaf and Tidyzq October 26, 2023 12:26
@SgLy SgLy self-assigned this Oct 26, 2023
@SgLy SgLy merged commit a36f8a5 into wechat-miniprogram:master Oct 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LastLeaf LastLeaf LastLeaf approved these changes

@Tidyzq Tidyzq Tidyzq approved these changes

Assignees

@SgLy SgLy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SgLy @LastLeaf @Tidyzq