Fix naming convention #107
Merged
+77
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cert` --> `certificate` `serialNo` --> `serialNumber` 备注： 本次修改没有选择将 `mch` 修改为 `merchant`，原因是代码中除了`WithMerchantCredential`，其他地方均使用 `mchXXX` 作为 `merchantXXX` 的简写（如：`mchID`，`mchPrivateKey`） 因此在本项目中，在符号命名中使用 `mch` 表示 `merchant` 的行为是一致的。在没有歧义的情况下，没有必要大动干戈进行修改。
可见部分包括： 1. 代码示例 2. 导出方法 3. 导出方法的参数 备注： 内部方法、内部代码等则没有进行此更改。
可见部分包括： 1. 代码示例 2. 导出方法 3. 导出方法的参数 同时为了保持兼容性，`SignResult` 以及 `SHA256WithRSASigner` 等类型的导出字段没有参与此重命名 备注： 内部方法、内部代码等则没有进行此更改。
MOD: 参考[GoDev#400363](https://go.dev/cl/400363)，在Go 1.16中使用staticcheck@0.2.2
EmmetZC
force-pushed
the
fix_naming_convention
branch
from
37d7d1b
to
d3a652b
Compare
xy-peng
approved these changes
May 13, 2022
alexkie007
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.