Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compile with JDK17 LTS, build with JDK21 #273

Merged
merged 2 commits into from
May 12, 2024
Merged

Conversation

xy-peng
Copy link
Contributor

@xy-peng xy-peng commented May 11, 2024

似乎 github actions/setup-java 不支持 Java1.8 了,所以使用 Java17,并设置了 sourceCompatibility/targetCompatibility 为 Java1.8

@xy-peng xy-peng requested review from wujunjiesd and a team May 11, 2024 11:43
@xy-peng xy-peng force-pushed the feat/compile_with_jdk17 branch 2 times, most recently from 11c218d to d7d6f5c Compare May 11, 2024 12:01
@xy-peng xy-peng closed this May 11, 2024
@xy-peng xy-peng reopened this May 11, 2024
Copy link

sonarcloud bot commented May 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wujunjiesd
Copy link

wujunjiesd commented May 12, 2024

确认业务代码未有逻辑变动,仅格式化代码

@xy-peng xy-peng merged commit 738c3e4 into main May 12, 2024
13 checks passed
@xy-peng xy-peng deleted the feat/compile_with_jdk17 branch May 12, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants