Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SoC] Go-wechaty Github Actions Optimization #8

Merged
merged 47 commits into from Sep 15, 2020
Merged

[SoC] Go-wechaty Github Actions Optimization #8

merged 47 commits into from Sep 15, 2020

Conversation

Nebell
Copy link
Contributor

@Nebell Nebell commented Aug 29, 2020

核心目标的相关代码。

@Nebell Nebell requested a review from a team as a code owner August 29, 2020 07:54
@Nebell
Copy link
Contributor Author

Nebell commented Aug 29, 2020

因为一些Token还没有设置,所以有些步骤会失败。

Copy link
Contributor

@dingdayu dingdayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Dockerfile 需要重新优化一下,最好使用多阶段构建。
    你可以从: Dockerfile 参考一下。
  • 关于 repository_dispatch 我想应该还有在 wechaty/go-wechaty 的部分,需要在这里贴一下,方便查看和理解。
  • 关于 Win 的部分,建议拆分出一个文件,那个目标的含义是跨平台,是想检测跨平台编译和运行的情况。

如果有不懂的可以随时微信联系我。

@Nebell Nebell requested a review from dingdayu September 7, 2020 11:23
@Nebell
Copy link
Contributor Author

Nebell commented Sep 9, 2020

对应 go-wechaty 部分 wechaty/go-wechaty#68

@dingdayu
Copy link
Contributor

dingdayu commented Sep 10, 2020

awesome, Like we communicated in WeChat.

Let's use GH_TOKEN instead of different tokens to facilitate debugging.
If necessary, we will set the token separately.

about buildx:

  1. https://yeasy.gitbook.io/docker_practice/buildx/buildkit
  2. https://github.com/docker/buildx#building-multi-platform-images
  3. https://docs.docker.com/buildx/working-with-buildx/

It is recommended that buildx submit new PR.

@dingdayu
Copy link
Contributor

抱歉,点错了 😂

@dingdayu dingdayu reopened this Sep 10, 2020
Copy link
Contributor

@dingdayu dingdayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dingdayu dingdayu merged commit 13c3102 into wechaty:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants