Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/system message wechaty #191

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Feat/system message wechaty #191

merged 2 commits into from
Jun 27, 2023

Conversation

hcfw007
Copy link
Member

@hcfw007 hcfw007 commented Apr 26, 2023

@hcfw007 hcfw007 requested a review from a team as a code owner April 26, 2023 07:28
@hcfw007 hcfw007 mentioned this pull request Apr 26, 2023
Closed
@hcfw007 hcfw007 mentioned this pull request May 9, 2023
Open
30 tasks
huan
huan requested changes Jun 14, 2023
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLEASE KEEP THE ORIGINAL NUMBER OR OUR ECOSYSTEM WILL BE BROKEN.

proto/wechaty/puppet/message.proto Outdated
MESSAGE_TYPE_CHAT_HISTORY = 8;
MESSAGE_TYPE_LOCATION = 9;
MESSAGE_TYPE_MINI_PROGRAM = 10;
MESSAGE_TYPE_CHAT_HISTORY = 4;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOPS! NEVER CHANGE THE ENUM NUMBER IN A PROTO FILE!

THIS WILL BREAK ALL PREVIOUS VERSION COMPATIBILITIES!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I was trying to make the message type enum in grpc match with the one in wechaty-puppet. I did not notice the diffrence in order.

@hcfw007 hcfw007 force-pushed the feat/system-message-wechaty branch from aaf16b9 to 0bb5853 Compare June 25, 2023 02:59
huan
huan approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan merged commit 7529560 into wechaty:main Jun 27, 2023
9 of 13 checks passed
@huan huan deleted the feat/system-message-wechaty branch June 27, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hcfw007 @huan