The JS bot.Room.find() API does not fit for Java

[diaozxin007]

In java,
A static field or method should be directly referred to by its class name instead of its corresponding object name.

so

 Room room = bot.Room.find("xxxx");

is not suitable for java api

so I suggest use like

Room room = bot.findRoom("xxx");

Room room = bot.createRoom();

the same as contact

Contact contact = bot.findContact("xxx");

Contact contact = bot.createContact();

[huan]

The bot.Room, bot.Contact, bot.Message design comes from wechaty/wechaty#518

We have a blog to record this process and some memorable information at https://blog.chatie.io/blessed-twins-bot/

Please read it first, and I'll go to dive into some Java design patterns first, then come back to you later and continue discussing under this issue.

[diaozxin007]

In java the code like

bot.Room.find()

cannot pass the code check tools just like:
find-bug
albaba p3c

so I think this is not a graceful api for java。

[huan]

If not bot.Room.find(), how about using bot.Room().find()?

[diaozxin007]

LGTM

[huan]

However, I still feel it will be more natural if we can use bot.Room.find().

What find-bug and p3c would say when they are linting the bot.Room.find() code?

If I have a Java class like the following presudo code:

class Bot {
  Room Room;
  public Bot() {
    this.Room = Room;
  }
}

bot = new Bot()
bot.Room.xxx()

What problem do they have in the Java language?

[diaozxin007]

that code confuse Class and Object.
You user

Room Room;

first Room is Class and second one is an Object.

so bot.Room is object. not a class.

this is different

Room.find(xxx)

which one is a Class.

so that is impossible for java

[huan]

Yes, I understand.

A class in Java might not be able to be referenced in a variable like the Python/JavaScript/ObjC, I guess there's no such concept like "MetaClass" in Java?

What if we use Kotlin: does Kotlin support that? I guess it can because it can be fully integrated with JavaScript?

[diaozxin007]

Our target is a Java sdk, we just use kotiln to develop a java sdk.

[huan]

You are right. The end-user will use it in the Java language environment.

So I will not persist the bot.Room.xxx() design anymore.

The bot.Room().xxx() is good.

[renjiayue]

我觉得此处的ROOM更应该是ROOMUtil