Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the MessageAwaiter plugin #60

Closed
huan opened this issue Oct 20, 2021 · 1 comment
Closed

Refactor the MessageAwaiter plugin #60

huan opened this issue Oct 20, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@huan
Copy link
Member

huan commented Oct 20, 2021

The MessageAwaiter currently added a global Wechaty interface waitForMessage() which polluted the global Wechaty environment.

plugin-contrib/src/contrib/message-awaiter.ts

Lines 21 to 27 in f1d08c7

declare module 'wechaty' {
class Wechaty {
waitForMessage(args: MessageAwaiterArgs): Promise<Message>
}
}

Need to remove the above code by refactoring this plugin. Maybe it will be changed to a helper function.

CC: @ssine

Related to PR
@huan huan added the bug Something isn't working label Oct 20, 2021
huan added a commit that referenced this issue Oct 21, 2021
@huan
refactor #60
8b1507a
huan added a commit that referenced this issue Oct 21, 2021
@huan
refactor #60
e722214
@huan
Copy link
Member Author

huan commented Oct 21, 2021

Implemented with wechaty-plugin-contrib@1.0.1

@huan huan closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huan