Add grpc.default_authority option for authorization #78
Conversation
|
|
There was a problem hiding this comment.
Thank you very much for adding this grpc.default_authority option for authorization!
Could you please create an issue and explain your design in detail about why you want to add this new feature, and how to use this new feature?
Especially, does this new feature will introduce breaking changes from our previous version?
Thank you very much!
|
I can use the authority to identify current user in gRPC server. |
|
Yes, I understand that we can use the authority to identify the current user in the gRPC server. Could you please confirm that: does this new feature will introduce any breaking changes from our previous version? |
Because the default gRPC server ignore the option, it can't break any previous version. |
|
Thank your very much for the explanation, and it is great to know that this new feature will not break any previous code! I'd love to merge this great new feature to the grpc service for testing. However, could you please add some documentation to our README before we can merge it, so that other developers will be able to learn this new feature easily? We will merge this PR after it is documentated, appreciate for your effort for make this module better! |
|
I had added some documentation for version 0.10.4. |
|
Merged. Cheers! |
|
@huan Thank you very much!Now bot can use the version 0.10.4 to connect our new gRPC server.The examples/ding-dong-bot works well!!!! Cheers! |
|
Your are welcome! BTW: it will be better if we can create an issue for any pull requests, and then link all related issues/prs to that issue, instead link to a Pull Request. Because the issue is created for discussing the feature/problem, but the PR is created for discussing specific code changes. Link to #124 |
Some hostie server don't use different port for service,It can use the authority to identify user.