fix recall message #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did you close the original PR #81? All the discussion is over there, closing that caused we lost all the conversations. |
|
Because of I made some mistakes when I updated this PR. So I close that PR and push a new one. I think we can discuss in the Issues? |
|
It's not good practice if you create a new PR in order to replace an old PR. The better practice should be continuing to modify the original PR until it had been merged. Link to wechaty/wechaty#1728 |
windmemory
approved these changes
Apr 15, 2019
| @@ -52,7 +52,9 @@ export function webMessageType ( | |||
| */ | |||
| case WebMessageType.SYS: | |||
| return MessageType.Text | |||
|
|
|||
| // add recall type | |||
There was a problem hiding this comment.
I think we don't need the comment here, since the type is clearly stated it's purpose.
|
@windmemory Thanks for the approvement. @wxul Thank you very much for the contribution, you did a great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this PR, some code has been changed