-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented friendship event #141
Conversation
…ppet-whatsapp into wechaty-puppet-0.41.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix eslint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert code style change.
* 2、whatsapp并非真正的好友关系,如果手机卡换了一个手机,通讯录没有他,则相当于非好友了,与传统好友的运作逻辑不符 | ||
*/ | ||
const contactIds = await cacheManager.getContactIdList() | ||
const isfriend = !!contactIds.find(c => c === contactId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
include
is better
private async onFriendship (id: string): Promise<void> { | ||
|
||
private async onFriendship (/* message id */id: string): Promise<void> { | ||
const contactId = await this.messageContact(id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this logic to manager.
No description provided.