Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented friendship event #141

Closed
wants to merge 6 commits into from

Conversation

kellyiscute
Copy link
Collaborator

No description provided.

src/manager.ts Outdated Show resolved Hide resolved
src/puppet-mixins/friendship.ts Outdated Show resolved Hide resolved
src/puppet-mixins/friendship.ts Outdated Show resolved Hide resolved
Copy link
Member

@su-chang su-chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix eslint

src/manager.ts Outdated Show resolved Hide resolved
src/manager.ts Outdated Show resolved Hide resolved
src/puppet-mixins/friendship.ts Outdated Show resolved Hide resolved
Copy link
Member

@su-chang su-chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert code style change.

* 2、whatsapp并非真正的好友关系,如果手机卡换了一个手机,通讯录没有他,则相当于非好友了,与传统好友的运作逻辑不符
*/
const contactIds = await cacheManager.getContactIdList()
const isfriend = !!contactIds.find(c => c === contactId)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include is better

private async onFriendship (id: string): Promise<void> {

private async onFriendship (/* message id */id: string): Promise<void> {
const contactId = await this.messageContact(id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this logic to manager.

@kellyiscute kellyiscute closed this Feb 9, 2022
@kellyiscute kellyiscute deleted the friendship-event branch February 9, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants