Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new property 'isMyMsg' to messagePayload #69

Merged
merged 7 commits into from Feb 6, 2022
Merged

Conversation

ericcug
Copy link
Contributor

@ericcug ericcug commented Feb 6, 2022

Get isMyMsg from offset 0x3C, int 1 is MyMessage and 0 is non-MyMessage.

@CLAassistant
Copy link

CLAassistant commented Feb 6, 2022

CLA assistant check
All committers have signed the CLA.

@atorber atorber merged commit 9e95b0e into wechaty:main Feb 6, 2022
@huan
Copy link
Member

huan commented Feb 6, 2022

Thank you very much for your contribution!

You are welcome to join Wechaty Contributor Program

1. Join Wechaty Organization

You've invited ericcug to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. (See also: wechaty/PMC#16)

2. Update Your Wechaty Contributor Profile

  1. Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
  2. Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room

We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.

Please add @lijiarui wechat: ruirui_0914 and send her this pr link. She will invite you into Wechaty Contributor Room

Cheers!

@huan
Copy link
Member

huan commented Feb 6, 2022

Please make sure the following requirements have been met for your PR before we can continue reviewing it:

  1. You have signed the CLA by clicking the [CLA | not signed yet] button from the comments.

@ericcug ericcug deleted the test branch February 6, 2022 12:18
@huan
Copy link
Member

huan commented Feb 6, 2022

There has a strange error message that prevents the CI turns green after merging this PR.

@ericcug could you please take a look at it and see what happened?

Thank you very much.

@ericcug
Copy link
Contributor Author

ericcug commented Feb 6, 2022

What message is? Maybe it relates to npm version in package.json? I see that @atorber had fix it. It could be the case that I have revert package.json file and commit it in mistake.

@huan
Copy link
Member

huan commented Feb 6, 2022

It seems that @atorber has already fixed it in the latest commit.

Thank you very much!

@atorber
Copy link
Collaborator

atorber commented Feb 8, 2022

@ericcug have you add @lijiarui wechat: ruirui_0914 ,we want invite you into Wechaty Puppet XP Contributor Room.

@ericcug
Copy link
Contributor Author

ericcug commented Feb 8, 2022

@atorber not yet. Add right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants