Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add corp base info to contact #109

Merged
merged 13 commits into from Aug 21, 2020
Merged

add corp base info to contact #109

merged 13 commits into from Aug 21, 2020

Conversation

windmemory
Copy link
Member

Related to issue wechaty/wechaty#2036

src/schemas/contact.ts Outdated Show resolved Hide resolved
@windmemory windmemory requested a review from huan August 19, 2020 06:47
src/schemas/contact.ts Outdated Show resolved Hide resolved
@windmemory
Copy link
Member Author

I came up with a new name for our internal & external concept: coworker

If the coworker is true, that means this contact is a coworker of the bot, the contact and the bot are in the same corp.

Other options are:

workmate
colleague
fellow

Refer here

I think the coworker is the best one, so used that in the code.

@windmemory windmemory requested a review from huan August 21, 2020 09:32
Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking the name carefully! that's a very important and hard work for our programmers!

coworker is very good, I like it too.

However, after reviewing the code I feel there is better to use the full name for our payloads because almost all names in Wechaty source code are using the full name, the pros of the full name are easy to understand and less ambiguity. For example, corp has two meanings in English.

So, please:

  1. change corp to corporation
  2. change desc to description

After we rename them to their full names, then this PR will be good to go.

@windmemory windmemory requested a review from huan August 21, 2020 11:06
@windmemory
Copy link
Member Author

Full name changed.

@windmemory
Copy link
Member Author

Shall we publish a stable version after we've added these changes?

src/puppet.ts Outdated Show resolved Hide resolved
src/puppet.ts Outdated Show resolved Hide resolved
src/schemas/contact.ts Outdated Show resolved Hide resolved
tests/fixtures/puppet-test/puppet-test.ts Outdated Show resolved Hide resolved
tests/fixtures/puppet-test/puppet-test.ts Outdated Show resolved Hide resolved
@windmemory
Copy link
Member Author

My bad, forgot to change the name across all changes :P

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huan huan merged commit 2eb3521 into master Aug 21, 2020
@huan huan deleted the add-corp-base-info branch August 21, 2020 11:20
@huan
Copy link
Member

huan commented Aug 21, 2020

Look great, merged, thanks for adding those WXWork related properties for our puppet system!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants