feat: 🎸 messageSendTextV2 #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
|
A better practice would be sending a PR to fix the linting first, and we can merge that PR very easily so that other PRs will not have to care about the linting again. |
huan
reviewed
Jun 14, 2023
| @@ -75,6 +75,7 @@ const messageMixin = <MinxinBase extends typeof PuppetSkeleton & CacheMixin>(bas | |||
| abstract messageSendMiniProgram (conversationId: string, miniProgramPayload: MiniProgramPayload) : Promise<void | string> | |||
| abstract messageSendPost (conversationId: string, postPayload: PostPayload) : Promise<void | string> | |||
| abstract messageSendText (conversationId: string, text: string, mentionIdList?: string[]) : Promise<void | string> | |||
| abstract messageSendTextV2 (conversationId: string, text: string | string[], mentionIdList?: string[]) : Promise<void | string> | |||
There was a problem hiding this comment.
I think we can just upgrade the messageSendText instead of adding a new V2; here are the reasons:
- the old Wechaty will always use the old Puppet
- the new Wechaty will use the new Puppet
- the new Wechaty will never use the old Puppet
So it seems that there's no chance that a Wechaty user will use string[] to call the old messageSendText function?
There was a problem hiding this comment.
OK. I'll create a new PR when wechaty 2.0 branch is created.
There was a problem hiding this comment.
May I know whether you agree with my comment or not?
Thanks!
There was a problem hiding this comment.
Totally. Unlike grpc and service, wechaty and puppet will never be mismatched.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
因为 chatie 的 eslint 有修改，会导致每个PR test都无法通过。为了避免重复修改lint，这个等没有别的意见了再改吧。
wechaty/wechaty#2394