Pass mention list up and down

[windmemory]

Refer to issue: wechaty/wechaty#1560

[huan]

Please keep the naming style consistent.

[huan]

Please keep the schema protection in your modification.

[huan]

Please do not simply merge those interfaces. They are separated by design.

We need to make sure that: either fromId or roomId must exist

The original design is to protect those data schema; please do not remove this protection.

[windmemory]

Okay, if that's the case, we should have no roomId in the MessagePayloadTo, and no fromId or toId in the MessagePayloadRoom, right?

Could you please explain a little about the reason that we have that at the first place?

[windmemory]

According to current design, maybe you will agree with this design?

export interface MessagePayloadBase {
  id            : string,

  // use message id to get rawPayload to get those informations when needed
  // contactId?    : string,        // Contact ShareCard

  filename?     : string,
  text?         : string,
  timestamp     : number,        // Unix Timestamp(in seconds)
  type          : MessageType,
}
/** @hidden */
export interface MessagePayloadRoom {
  fromId?       : string,
  mentionIdList?: string[],   // Mentioned Contacts' Ids
  roomId        : string,
  toId?         : string,   // if to is not set, then room must be set
}
/** @hidden */
export interface MessagePayloadTo {
  fromId        : string,
  mentionIdList?: string[],   // Mentioned Contacts' Ids
  roomId?       : string,
  toId          : string,   // if to is not set, then room must be set
}
export type MessagePayload = MessagePayloadBase
                            & (
                                MessagePayloadRoom
                              | MessagePayloadTo
                            )

[huan]

Sorry but I don't think this is right: the MessagePayloadTo should never have the mentionIdList property.

[windmemory]

Then why it has roomId originally? That doesn't make sense. Also why MessagePayloadRoom has toId? Is there any reason for that?

[windmemory]

So what was the reason that we have the roomId originally? Is that for making typescript happy? Or some other reason? I spent a lot of time trying to make it work with the design that only have roomId and mentionIdList on the MessagePayloadRoom and only have toId and fromId on the MessagePayloadTo, but haven't figured out the right answer to that. I am really curious about the original design and how to make it work.

[huan]

To be honest, I forgot.

The only thing that I had remembered is that it was designed for a purpose.

Would love to discuss it with you when we got time, but let's just move forward and leave this as it is.

[windmemory]

Cool, let's talk then.

And thanks for merging this PR :)