Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conver timestamp field #34

Merged
merged 6 commits into from
Sep 24, 2020
Merged

conver timestamp field #34

merged 6 commits into from
Sep 24, 2020

Conversation

wj-Mcat
Copy link
Collaborator

@wj-Mcat wj-Mcat commented Sep 23, 2020

Becuase of technical debt, I define the timestamp to time_stamp field. To keep consistent with chatie/grpc's defination, this pr gets born.

@wj-Mcat wj-Mcat requested a review from a team as a code owner September 23, 2020 08:12
fish-ball
fish-ball reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@fish-ball fish-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fish-ball
fish-ball approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@fish-ball fish-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wj-Mcat wj-Mcat merged commit 6318414 into wechaty:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fish-ball fish-ball fish-ball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wj-Mcat @fish-ball