Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base64 to_file support #25

Merged
merged 2 commits into from Aug 4, 2020
Merged

base64 to_file support #25

merged 2 commits into from Aug 4, 2020

Conversation

MrZilinXiao
Copy link
Member

@MrZilinXiao MrZilinXiao commented Aug 1, 2020

I found that there is no base64 to_file support in python-wechaty-puppet, leading to examples here won't trigger the image saving action since img = await msg.to_file_box() makes img a base64-filebox.

image

https://github.com/wechaty/python-wechaty-getting-started/blob/1cb320513536c74178023be2bf511bd233628990/examples/advanced/message-file-bot.py#L48

@MrZilinXiao MrZilinXiao requested a review from a team as a code owner August 1, 2020 14:57
Copy link
Collaborator

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Aug 2, 2020

It's great to see that you have your contribution to python-wechaty. This support is welcome.

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Aug 2, 2020

You should update the version in VERSION file to deploy the wechaty-puppet-hostie to pypi repo. @MrZilinXiao Waiting for your next bump of version.

@MrZilinXiao
Copy link
Member Author

You should update the version in VERSION file to deploy the wechaty-puppet-hostie to pypi repo. @MrZilinXiao Waiting for your next bump of version.

Like pumping 0.0.15 to 0.0.16 like this?
Sorry for the inconvenience since it's my first time to submit PR to python-wechaty puppet.

Copy link
Collaborator

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Aug 4, 2020

@lijiarui the student @MrZilinXiao has become our wechaty contributor, please invite him.

@huan
Copy link
Member

huan commented Aug 4, 2020

@wj-Mcat Awesome, and welcome @MrZilinXiao !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants