Skip to content

Commit

Permalink
do not specify chromeServiceBuilder
Browse files Browse the repository at this point in the history
  • Loading branch information
huan committed Oct 24, 2016
1 parent beadd7d commit 09099fc
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions src/puppet-web/browser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -223,13 +223,18 @@ export class Browser extends EventEmitter {
/**
* http://stackoverflow.com/a/27733960/1123955
* issue #56
*/
* only need under win32 with cygwin
* and will cause strange error:
* `The previously configured ChromeDriver service is still running. You must shut it down before you may adjust its configuration.`
const chrome = require('selenium-webdriver/chrome')
const path = require('chromedriver').path
const service = new chrome.ServiceBuilder(path).build()
chrome.setDefaultService(service)
*/

const options = {
args: ['--no-sandbox'] // issue #26 for run inside docker
// , binary: require('chromedriver').path
Expand Down Expand Up @@ -696,7 +701,8 @@ export class Browser extends EventEmitter {
}

public loadSession(): Promise<any> {
log.verbose('PuppetWebBrowser', `loadSession(${this.setting.sessionFile})`)
log.verbose('PuppetWebBrowser', 'loadSession() from %s', this.setting.sessionFile ? this.setting.sessionFile : '' )

if (!this.setting.sessionFile) {
return Promise.reject(new Error('loadSession() no sessionFile'))
} else if (this.dead()) {
Expand Down

0 comments on commit 09099fc

Please sign in to comment.