Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance RoomMemberQueryFilter #2069

Closed
treeguard opened this issue Sep 27, 2020 · 3 comments
Closed

enhance RoomMemberQueryFilter #2069

treeguard opened this issue Sep 27, 2020 · 3 comments

Comments

@treeguard
Copy link

Is your feature request related to a problem? Please describe.
The current RoomMemberQueryFilter doesn't support query by wxid (id of Contact), can we support this?

Describe the solution you'd like
Add id as a string type in RoomMemberQueryFilter
Describe alternatives you've considered

  1. Find all contacts for the room and find out the matched id
  2. Load the contact by id first and use Room.has function, however, if the contact is not a friend of the bot, I am not sure if we can load the contact by id

Additional context
Add any other context or screenshots about the feature request here.

[enhancement]

@AliBinBeshr

This comment was marked as off-topic.

@AliBinBeshr

This comment was marked as off-topic.

Copy link

dosubot bot commented Nov 18, 2023

Hi, @treeguard. I'm Dosu, and I'm helping the wechaty team manage their backlog. I wanted to let you know that we are marking this issue as stale.

From what I understand, the issue is about the RoomMemberQueryFilter not supporting querying by wxid (id of Contact). The proposed solution was to add id as a string type in RoomMemberQueryFilter. It seems that the proposed solution has been implemented and the issue has been resolved.

If this issue is still relevant to the latest version of the wechaty repository, please let us know by commenting on the issue. Otherwise, feel free to close the issue yourself or it will be automatically closed in 7 days.

Thank you for your contribution to the wechaty repository!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 18, 2023
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2023
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants