New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better CSS Handling (Change Enqueue to head) #28

Closed
philiparthurmoore opened this Issue Aug 23, 2014 · 4 comments

Comments

Projects
None yet
1 participant
@philiparthurmoore
Copy link
Member

philiparthurmoore commented Aug 23, 2014

See https://twitter.com/michaelarestad/status/503047788176101376 from @MichaelArestad. I'll release this fix before September 1st.

philiparthurmoore pushed a commit that referenced this issue Aug 31, 2014

Philip Arthur Moore
@philiparthurmoore

This comment has been minimized.

Copy link
Member

philiparthurmoore commented Aug 31, 2014

@MichaelArestad Just fixed this. The styles will simply be output via wp_head. Do you see any potential issues here?

@philiparthurmoore

This comment has been minimized.

Copy link
Member

philiparthurmoore commented Aug 31, 2014

Here's the changeset.

philiparthurmoore pushed a commit that referenced this issue Aug 31, 2014

Philip Arthur Moore
@philiparthurmoore

This comment has been minimized.

Copy link
Member

philiparthurmoore commented Aug 31, 2014

Noting that with this method the following code would be needed to ditch the styling:

    if ( class_exists( 'Subtitles' ) &&  method_exists( 'Subtitles', 'subtitle_styling' ) ) {
        remove_action( 'wp_head', array( Subtitles::getInstance(), 'subtitle_styling' ) );
    }
@philiparthurmoore

This comment has been minimized.

Copy link
Member

philiparthurmoore commented Aug 31, 2014

Plugin bumped to 2.0.0 in 6e3a46d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment