-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18기 송나은] React-Westagram 로그인, 메인페이지 필수기능 구현 완료 #3
Open
songbetter
wants to merge
17
commits into
master
Choose a base branch
from
feature/naeunsong
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songbetter
changed the title
Feature/naeunsong
[18기 송나은] Mission 1) Login | 사용자 입력 데이터 저장 구현 완료
Mar 6, 2021
songbetter
changed the title
[18기 송나은] Mission 1) Login | 사용자 입력 데이터 저장 구현 완료
[18기 송나은] Mission 1) Login | 사용자 입력 데이터 저장 기능 구현 완료
Mar 6, 2021
songbetter
changed the title
[18기 송나은] Mission 1) Login | 사용자 입력 데이터 저장 기능 구현 완료
[18기 송나은] Mission 2) Login | 로그인 버튼 활성화 기능 구현 완료
Mar 6, 2021
songbetter
changed the title
[18기 송나은] Mission 2) Login | 로그인 버튼 활성화 기능 구현 완료
[18기 송나은] Mission 3 - Main | 댓글 기능 구현 완료
Mar 8, 2021
songbetter
changed the title
[18기 송나은] Mission 3 - Main | 댓글 기능 구현 완료
[18기 송나은] Mission 4 - Main | 댓글 컴포넌트화 + props로 데이터 전달 완료
Mar 8, 2021
whoyoung90
reviewed
Mar 9, 2021
GEUNNN
reviewed
Mar 9, 2021
bonbon0202
reviewed
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나은님! 수고 많으셨습니다 :)
코드가 전체적으로 깔끔하네요!
리뷰 보시고 리팩토링해주세요!
songbetter
changed the title
[18기 송나은] Mission 4 - Main | 댓글 컴포넌트화 + props로 데이터 전달 완료
[18기 송나은] React-Westagram 로그인, 메인페이지 필수기능 구현 완료
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
수정 사항 간략한 한줄 요약
수정 사항들 자세한 내용
: 컴포넌트별로 scss 파일도 함께 분리. 메인 페이지 컴포넌트-Header, Feeds, MainRight로 분리
: Input창에 입력된 ID와 PW를 state에 저장하는 기능.
: ID에 '@' 포함, PW가 5자 이상일 때 버튼이 활성화 되는 기능.
: 인증 과정을 거쳐 인증된 사용자만 main 페이지로 이동할 수 있도록 함.
: 댓글창에 댓글 입력 후 엔터를 누르거나 게시 버튼을 클릭하면 댓글이 추가되는 기능.
: JSX로 작성한 댓글 영역 컴포넌트화. 부모 컴포넌트에서 데이터 전달.
: Feeds > Feed > Comment / MainRight > Recommend > RecommendInfo 컴포넌트 분리.
: Mock Data 활용하여 UI 최소화
기타 질문 및 특이 사항
체크 리스트