[ADD] 상품 정보 UPDATE #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigfanoftim
requested changes
Dec 6, 2022
| const productUpdate = catchAsync(async (req, res) => { | ||
| const { productId } = req.params; | ||
| const { name, description, price, location, latitude, longitude, product_status_id, category_id, image_url } = req.body; | ||
| const userId = 1; //req.user.id; |
There was a problem hiding this comment.
토큰을 처리할 수 있는 코드를 만드셔서 이 부분은 하드 코딩되어 있을 필요가 없어보입니다.
|
|
||
| await productService.productUpdate( productId, name, description, price, location, latitude, longitude, product_status_id, category_id, image_url); | ||
|
|
||
| return res.status(201).json({ |
There was a problem hiding this comment.
201은 update를 의미하는 상태 코드가 아니니 수정해주세요.
src/routes/product.router.js
Outdated
| @@ -0,0 +1,7 @@ | |||
| const routes = require("express").Router(); | |||
| const productController = require("../controllers/product.controller"); | |||
| //const { verifyToken } = require("../utils/verifyToken") | |||
Gyelanjjim
force-pushed
the
feature/productUpdate
branch
from
259df5c
to
72ad7ed
Compare
bigfanoftim
requested changes
Dec 7, 2022
| bucket: process.env.BUCKET_NAME, | ||
| contentType: multerS3.AUTO_CONTENT_TYPE, | ||
| key: (req, file, callback) => { | ||
| const uploadDirectory = req.query.directory ?? '' |
There was a problem hiding this comment.
req.query.directory를 보니 어디다 저장할지 클라이언트로 부터 받으려고 하시는게 맞을까요?
굳이 그럴 필요가 없어보입니다. 버킷 내 어느 디렉토리에 저장할지는 각 서비스의 서버에서 관리하는 것이 더 좋아보입니다.
|
직접 작성한 코드가 아니라 긁어온 자료라서 뭘 어떻게 물어봐야할지 모르겠습니다 AWS S3 생성, routes: ...라는 미들웨어를 사용한다는 것까지 이해했습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:: 최근 작업 주제 (하나 이상의 주제를 선택해주세요.)
:: 구현 목표 - 해당 브랜치(PR)에서 구현하고자 하는 하나의 목표 작성
:: 구현 사항 설명 - 해당 브랜치(PR)에서 작업한 내용 작성
:: 테스트 결과 이미지
:: 기타 질문 및 특이 사항