-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a wp-cli.yml file #33
Comments
@dnaber-de Something like you can see in d84cdf9 ? |
The steps can get tested by checking out the |
There are even more possible configuration values. We might want to allow those as well. Possible ways to add them:
If we do that, I'd vote for the Another thing that needs discussion is the correct path to use for the |
About the correct path for About the other configuration values of WP-CLI: the only option that depends on the setup of WPStarter is the |
@dnaber-de Thanks for the update. Could you check out the branch and give it a test ride if you got some time? |
That looks pretty promising
But for some reason the
This is my WPStarter config:
However, If I change to
The content of the generated
but it should be
according to my configuration. |
Fixed with 1a422cb. The target dir for the To test this, I ran a quick test and can confirm that both the location inside and the file itself are generated properly. @dnaber-de Could you please try again? |
Now, the path inside However, the path where you place the Example:
This is a typical repository of a WPStarter project. (WP install directory is Long story short, public function targetPath( ArrayAccess $paths )
{
return rtrim( $paths['root'], "/" )."/wp-cli.yml";
} Just tested it locally and it works as expected. Edit By the way, the file |
FWIW, https://github.com/bradp/vv already creates a wp-cli.yml file for VVV installs. |
@dnaber-de Changed with cdf1557. |
For some unidentified reason, filter_var() will return true for "0" PHP version 5.6.18
@Giuseppe-Mazzapica where do we go with this? New milestone 3.0.*? Or abandon it? |
I still owe you a comment on the last fix. Didn't found time to test it yet. |
@dnaber-de No worries. Actually I overread the change in labels and did not see the assigned projects from @Giuseppe-Mazzapica. I moved the status to in progress. Would be nice if you can test it so we can merge and close it. |
We might consider adding the following lines as Composer is used to manage packages: disabled_commands:
- plugin install
- plugin uninstall
- plugin update
- theme install
- theme update |
That seems convenient. I would limit it to these (and not disallow |
According to the discussin in wecodemore#33 this commit places the wp-cli.yml to the project root folder. It also fixes the `path` value inside to the WordPress install path.
Place wp-cli.yml in project root folder #33
According to the discussin in #33 this commit places the wp-cli.yml to the project root folder. It also fixes the `path` value inside to the WordPress install path.
What do you think about creating a
wp-cli.yml
in the project root to specify the path to WP core. The content would just look like that:It would allow to use WP-CLI from the same working directory as one would use composer from. Otherwise you have to change directory to the WP root or specify a parameter on each command.
Edit: The local copy of this file should then go to the
.gitignore
:wp-cli.local.yml
The text was updated successfully, but these errors were encountered: