Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat - [webpack v5 migration] #92

Conversation

christin-wednesday
Copy link
Contributor

Ticket Link


Related Links


https://webpack.js.org/migrate/5/

Description


  1. Updated all plugins to the latest versions.
  2. Tested, updated options and downgraded plugins to make everything work for Webpack 4

Steps to Reproduce / Test


  1. Tryyarn webpack configtest internals/webpack/webpack.config.prod.babel.js to test the config.

GIF's


Signed-off-by: Chris <christin@wednesday.is>
Signed-off-by: Chris <christin@wednesday.is>
fix: used a fixed version of the offline plugin
Signed-off-by: Chris <christin@wednesday.is>
fix: favicon

Signed-off-by: Chris <christin@wednesday.is>
}),

new HashedModuleIdsPlugin({
hashFunction: 'sha256',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"whatwg-fetch": "3.0.0"
}
},
"sideEffects": false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -68,13 +68,10 @@
]
},
"pre-commit": "lint:staged",
"resolutions": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature requires an additional package called https://github.com/rogeriochaves/npm-force-resolutions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the property since this was not working.

"@babel/preset-react": "^7.14.5",
"@babel/register": "7.14.5",
"@babel/runtime": "^7.14.6",
"@lcdp/offline-plugin": "^5.1.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Chris <christin@wednesday.is>
Signed-off-by: Chris <christin@wednesday.is>
Signed-off-by: Chris <christin@wednesday.is>
Signed-off-by: Chris <christin@wednesday.is>
@christin-wednesday christin-wednesday merged commit 664be26 into wednesday-solutions:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants