New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection failure to the Kubernetes Slack channel #699
Comments
AFAIK, wee-slack currently badly handles large workspaces. |
There was another user on IRC reporting the same issue in late April, so apparently this is an issue for some teams. Not sure which teams it affects, maybe it's caused by the size, or possibly something else. We would have to do some rewriting to support this. I notice that in addition to not supporting In general (as long as the API endpoints wee-slack uses works for the team), wee-slack handles fairly large teams pretty well in my experience. I am for example on a team with 11000 users and 16000 channels without any particular issues. |
Seems still an issue:
which is quite sad because I really hate their web UI :( |
@dtantsur: Yes, that's why this issue is still open, it hasn't been fixed. Unfortunately, I think there is some info we can't get from any other API calls than |
The k8s slack org restricts application installation and the admins reject requests for wee-slack due to the exposure of email addresses by the |
rtm.start is deprecated and will stop working on September 20, 2022. This patch replaces it with several other API endpoints to get the info we need. The old code to use rtm.start is still kept because xoxs tokens doesn't work with the users.conversations API endpoint, but it will probably be removed soon (it's not possible to get new xoxs tokens anyways). This is a necessary step for #699 and #844
rtm.start is deprecated and will stop working on September 20, 2022. This patch replaces it with several other API endpoints to get the info we need. The old code to use rtm.start is still kept because xoxs tokens doesn't work with the users.conversations API endpoint, but it will probably be removed soon (it's not possible to get new xoxs tokens anyways). This is a necessary step for #699 and #844
rtm.start is deprecated and will stop working on September 20, 2022. This patch replaces it with several other API endpoints to get the info we need. The handle_rtmstart method is kept for the test setup to work, but this setup should also be replaced with the new API endpoints. This is a necessary step for #699 and #844
rtm.start is deprecated and will stop working on September 20, 2022. This patch replaces it with several other API endpoints to get the info we need. The handle_rtmstart method is kept for the test setup to work, but this setup should also be replaced with the new API endpoints. This is a necessary step for #699 and #844
rtm.start is deprecated and will stop working on September 20, 2022. This patch replaces it with several other API endpoints to get the info we need. The handle_rtmstart method is kept for the test setup to work, but this setup should also be replaced with the new API endpoints. This is a necessary step for #699 and #844
This has been fixed with the v2.9.0 release. Note that you have to use a session token since the wee-slack app is not approved. The startup is very slow though because the way wee-slack currently works it requires all users to be loaded on start and this workspace has a ton of users. I tested now and it took 8 minutes for me. This is something I'm working on addressing, but it will probably take a while.
This doesn't make any sense. wee-slack only exposes what's already available from the Slack APIs of course. And I tested now, and the email address is not shown by the |
I agree with the logic here; that's just the reasoning I was given by the admins of that particular workspace when requesting the installation of
Perhaps Slack has removed this info from the endpoint that's called? I don't follow their API changes, but I do know that when I made that comment, I was able to view user's email addresses in other workspaces where wee-slack had been installed and a session token wasn't being used. |
Yes, of course, the comment wasn't directed at you, just at the statement. Sorry if it came across a bit crass.
Yes, email addresses are normally shown by |
Crass? Not what I took your comment as, at all :)
That must be a new administration setting. I've moved the communities I managed away from Slack some time ago, so I haven't had administrative access to a workspace for quite some time, but I certainly don't remember that being configurable for a workspace. |
No idea if it's new or not, but this is the setting: But huh, I tested this setting and I see that with it set to "No one" the email address is not available from the API anymore when using session tokens, but it's still available when using OAuth tokens. That was surprising to me, but I see that they actually warn about it there. Seems like a weird choice by Slack to me. So then what the admins said that email addresses will be shown in Anyways, since you can use session tokens, it shouldn't really be an issue if the app isn't and won't be approved. |
Edit: See below. |
Eh, sorry, I mixed up the responses, the email addresses are still available using OAuth tokens, so see the original comment... |
Latest wee-slack (e00965c) can't connect to the Kubernetes community chat (using a 106-character
xoxs-*
token from a browser): https://slack.k8s.io/The connection error message is:
There is a note in the API docs https://api.slack.com/methods/rtm.start:
WeeChat 2.4
The text was updated successfully, but these errors were encountered: