Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use SKS for distributing weechat signing key #97

Closed
dngray opened this issue Jul 18, 2019 · 3 comments
Closed

Do not use SKS for distributing weechat signing key #97

dngray opened this issue Jul 18, 2019 · 3 comments
Assignees
Labels
feature New feature request

Comments

@dngray
Copy link

dngray commented Jul 18, 2019

Hi,

The weechat signing key is being spammed, the instructions on https://weechat.org/download/ should not use the SKS network, users attempting the instruction to import the key will break their gnupg installation.

Currently the signing key on SKS is 180MB.

Background:

@wiktor-k
Copy link

wiktor-k commented Jul 18, 2019

Agreed. Alternatively weechat should put their key on https://keys.openpgp.org (that is immune to spamming) and advise downloading from that keyserver. Or use Web Key Directory and gpg --sender when creating the signature (just like kernel.org).

Edit:
I'd revise the instructions to use the following:

  1. gpg --locate-key webmaster@weechat.org
  2. gpg --verify weechat-2.5.tar.xz.asc weechat-2.5.tar.xz
  3. Check if the fingerprint at the end matches master key fingerprint. Importing weechat key and not checking the signing fingerprint at the end of verify does not cover the case when weechat would be signed by another key present in the keyring.

@flashcode
Copy link
Member

This is an issue on weechat.org, not WeeChat itself, so I move the issue in the appropriate repository.

@flashcode flashcode transferred this issue from weechat/weechat Jul 24, 2019
@flashcode flashcode added the feature New feature request label Jul 24, 2019
@flashcode flashcode self-assigned this Jul 29, 2019
@flashcode flashcode added the in progress Someone is working on this issue label Jul 29, 2019
@flashcode flashcode removed the in progress Someone is working on this issue label Jul 29, 2019
@flashcode
Copy link
Member

Fixed, thanks for pointing the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

No branches or pull requests

3 participants