Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weechat removing whitespace from the end of messages, breaking IRC art #1513

Closed
acidvegas opened this issue May 19, 2020 · 3 comments
Closed
Assignees
Labels
bug Unexpected problem or unintended behavior
Milestone

Comments

@acidvegas
Copy link

Bug summary

IRC Art is breaking on weechat users because most IRC art doesnt have a ^O at the end of each line, so when you have art that is just something like "^C02,04TEST" with a bunch of spaces after it for a solid background color, it will not show it, because it is trimming the whitespace at the end.

Picture of the same ascii on weechat vs irssi: https://imgur.com/a/ENI6ccy
Link to original ascii file: https://raw.githubusercontent.com/ircart/ircart/master/mircart/gantgorbilla.txt

@acidvegas acidvegas added the bug Unexpected problem or unintended behavior label May 19, 2020
@flashcode
Copy link
Member

Thanks for reporting the issue, it is a regression introduced in WeeChat 2.5 (commit 2b70d71), where I added new flags for API function string_split.

@flashcode flashcode self-assigned this May 19, 2020
@flashcode flashcode added this to the 2.9 milestone May 19, 2020
@acidvegas
Copy link
Author

acidvegas commented May 19, 2020

No problem. Status on unbanning me from #weechat, lol

@weechatter
Copy link
Contributor

no status. Banned for good reasons. lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants