Possible regression in WeeChat 3.0 when using spell_suggest in input.items

[tofurky]

Bug summary

In WeeChat 3.0, if a misspelling occured in the previous line sent to a buffer, the text input field will continue to show suggestions for that misspelling in the now-empty input buffer.

Steps to reproduce

• Set spell.check.enabled = on
• Set input.items = "[input_prompt]+(away),[input_search],[input_paste],input_text,[spell_suggest]"
• Send text with a detected misspelling to a buffer

Current behavior

Before sending text to a buffer, for example "weechat has a regression", the following is seen in the input field:

[@nick(ZiQw)] weechat has a regression [wee chat,wee-chat,Wichita]

After sending to the buffer, the following is seen in the input field:

[@nick(ZiQw)] [wee chat,wee-chat,Wichita]

Redrawing the window with Ctrl-L has no effect, nor does switching between buffers. Hitting space (and optionally, backspace) hides the suggestions.

Expected behavior

After sending the text to the buffer, the following should be seen, even if a misspelling was detected:

[@nick(ZiQw)]

Suggested solutions

Maybe 299f74b is related. I haven't bisected.

Additional information

2.9 was unaffected.

spell.conf:

[color]
misspelled = lightred
suggestion = lightblue
suggestion_delimiter_dict = cyan
suggestion_delimiter_word = cyan

[check]
commands = "ame,amsg,away,command,cycle,kick,kickban,me,msg,notice,part,query,quit,topic"
default_dict = "en"
during_search = off
enabled = on
real_time = off
suggestions = 3
word_min_length = 2

[dict]

[look]
suggestion_delimiter_dict = " / "
suggestion_delimiter_word = ","

[option]

Compiled using dpkg-buildpkg with the following in debian/rules:

        cmake .. \
                -DCMAKE_INSTALL_PREFIX:FILEPATH=/usr \
                -DLIBDIR=/usr/lib/${DEB_HOST_MULTIARCH} \
                -DENABLE_DOC:BOOL=ON \
                -DENABLE_MAN:BOOL=ON \
                -DCMAKE_BUILD_TYPE:STRING=RelWithDebInfo \
                -DCMAKE_C_FLAGS_RELWITHDEBINFO:STRING="$(CFLAGS) -D_FORTIFY_SOURCE=2" \
                -DCMAKE_MODULE_LINKER_FLAGS_RELWITHDEBINFO:STRING="$(LDFLAGS)" \
                -DCMAKE_SKIP_RPATH:BOOL=ON \
                -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON \
                -DENABLE_RUBY:BOOL=OFF \
                -DENABLE_LUA:BOOL=OFF \
                -DENABLE_TCL:BOOL=OFF \
                -DENABLE_GUILE:BOOL=OFF \
                -DENABLE_JAVASCRIPT:BOOL=OFF \
                -DENABLE_PHP:BOOL=OFF

• WeeChat version: 3.0
• OS, distribution and version: Debian 10 amd64 (over SSH)
• Terminal: mate-terminal 1.24.0 (on Ubuntu 20.04 amd64)
• Terminal multiplexer (screen/tmux/…/none): tmux 2.8

[tofurky]

I can confirm that eb90a73 fixes this when applied onto 3.0. Thanks.