Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting window title on suckless terminal do not work #1882

Closed
ragnarov opened this issue Feb 17, 2023 · 0 comments
Closed

setting window title on suckless terminal do not work #1882

ragnarov opened this issue Feb 17, 2023 · 0 comments
Assignees
Labels
bug Unexpected problem or unintended behavior
Milestone

Comments

@ragnarov
Copy link

ragnarov commented Feb 17, 2023

Bug summary

Weechat don't change terminal's window title on suckless terminal.
But vim can change the title.
Also I have scripts that can do it.
Someone from #suckless (oftc) suggested the problem was here :
https://github.com/weechat/weechat/blob/master/src/gui/curses/gui-curses-window.c#L2589

I also talked to the devs at irc. This is here as a reminder.

Steps to reproduce

Just run weechat.

Current behavior

Don't change title.

Expected behavior

Should change title.

Suggested solutions

    else if ((strncmp (envterm, "xterm", 5) == 0)
             || (strncmp (envterm, "rxvt", 4) == 0)
             || (strncmp (envterm, "alacritty", 9) == 0)
             || (strcmp (envterm, "Eterm") == 0)
             || (strcmp (envterm, "aixterm") == 0)
             || (strcmp (envterm, "iris-ansi") == 0)
             || (strcmp (envterm, "dtterm") == 0))
    {
        printf ("\33]0;%s\7", new_title);
    }

Add st to that list.
Or make that the default condition.

Additional information

None


  • WeeChat version: 3.8
  • OS, distribution and version: Arch Linux 5.15.90-1-lts
  • Terminal: Suckless
  • Terminal multiplexer (screen/tmux/…/none): none
@ragnarov ragnarov added the bug Unexpected problem or unintended behavior label Feb 17, 2023
flashcode added a commit that referenced this issue Apr 23, 2023
@flashcode flashcode added this to the 4.0.0 milestone Apr 23, 2023
@flashcode flashcode self-assigned this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants