WeeChat crashes on exit when both title.py and autosort.py are loaded with Python 3.12 (voidlinux) #2046

laemeiqu · 2023-11-21T17:42:25Z

Bug summary

When using weechat-4.1.1_1 and weechat-python-4.1.1_1 under voidlinux. When scripts title.py and autosort.py are both installed weechat crashes on exit.

Steps to reproduce

1. /script load title.py
2. /script load autosort.py
3. /exit

If no crash at this time then reloading weechat and /exit will definitely crash weechat in voidlinux.

Current behavior

Weechat crashes during exit when both scripts are installed.

Expected behavior

Weechat doesn't crash on exit when both scripts are installed.

Additional information

After bulding debug packages in voidlinux

gdb /usr/bin/weechat

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff626f76d in PyObject_GC_UnTrack () from /usr/lib/libpython3.12.so.1.0

bt full

#0  0x00007ffff626f76d in PyObject_GC_UnTrack () from /usr/lib/libpython3.12.so.1.0
No symbol table info available.
#1  0x00007ffff62a2099 in ?? () from /usr/lib/libpython3.12.so.1.0
No symbol table info available.
#2  0x00007ffff62251e5 in ?? () from /usr/lib/libpython3.12.so.1.0
No symbol table info available.
#3  0x00007ffff6220276 in ?? () from /usr/lib/libpython3.12.so.1.0
No symbol table info available.
#4  0x00007ffff6225bd5 in _PyModule_ClearDict () from /usr/lib/libpython3.12.so.1.0
No symbol table info available.
#5  0x00007ffff62eaaf6 in ?? () from /usr/lib/libpython3.12.so.1.0
No symbol table info available.
#6  0x00007ffff62ead6b in Py_EndInterpreter () from /usr/lib/libpython3.12.so.1.0
No symbol table info available.
#7  0x00007ffff66ea2a0 in weechat_python_unload (script=0x555555df3550)
    at /builddir/weechat-4.1.1/src/plugins/python/weechat-python.c:975
        rc = <optimized out>
        interpreter = 0x7ffff5bec910
        filename = 0x555555e69230 "/home/roald/.local/share/weechat/python/autoload/title.py"
#8  0x00007ffff66ea375 in weechat_python_unload_all ()
    at /builddir/weechat-4.1.1/src/plugins/python/weechat-python.c:1024
No locals.
#9  0x00007ffff670a12c in plugin_script_end (weechat_plugin=weechat_plugin@entry=0x555555b5cd10, 
    plugin_data=plugin_data@entry=0x7ffff671bd00 <python_data>)
    at /builddir/weechat-4.1.1/src/plugins/plugin-script.c:1789
        scripts_loaded = 1
#10 0x00007ffff66eb681 in weechat_plugin_end (plugin=0x555555b5cd10)
    at /builddir/weechat-4.1.1/src/plugins/python/weechat-python.c:1563
No locals.
#11 0x00005555555fadb6 in plugin_unload (plugin=0x555555b5cd10)
    at /builddir/weechat-4.1.1/src/plugins/plugin.c:1253
        end_func = <optimized out>
        name = 0x555555fcd320 "python"
#12 0x00005555555fae69 in plugin_unload_all () at /builddir/weechat-4.1.1/src/plugins/plugin.c:1305
        plugins_loaded = <optimized out>
#13 0x00005555555fb122 in plugin_end () at /builddir/weechat-4.1.1/src/plugins/plugin.c:1425
No locals.
#14 0x00005555555630c2 in weechat_end (gui_end_cb=0x5555555f43d0 <gui_main_end>)
    at /builddir/weechat-4.1.1/src/core/weechat.c:708
No locals.
#15 0x00005555555620d6 in main (argc=1, argv=0x7fffffffe118)
    at /builddir/weechat-4.1.1/src/gui/curses/normal/main.c:45
No locals.

WeeChat version: weechat-4.1.1_1
OS, distribution and version: Voidlinux (fully updated on Tue Nov 21 2023)
Terminal: foot
Terminal multiplexer (screen/tmux/…/none): none

The text was updated successfully, but these errors were encountered:

laemeiqu · 2023-11-21T18:09:58Z

If title is unloaded before autosort then weechat does not crash on exit:

/script unload title
/exit
no crash

If autosort is unloaded before title then weechat does crash on exit or on unloading of title:

/script unload autosort
/script unload title
crash

flashcode · 2023-11-22T16:22:54Z

Does the crash happen with any Python script?
Did you try with two different scripts (if possible very small scripts, doing almost nothing)?

laemeiqu · 2023-11-23T22:37:43Z

I can reproduce this crash with other python plugins. I reproduced the crash with the scripts go.py and grep.py both installed.

If grep.py is unloaded before go.py then weechat does not crash on exit:

/script unload grep.py
/exit
no crash

If go.py is unloaded before grep.py then weechat does crash on exit or on unloading of grep.py:

/script unload go.py
/script unload grep.py
crash

Note: going straight for /exit when grep.py and go.py are both installed and loaded also results in the crash.

flashcode · 2023-11-30T08:27:56Z

Hi,
I can not reproduce on Debian (Sid/unstable) with Python 3.11 (not 3.12, that could explain), is it possible to write a short Dockerfile based on voidlinux to reproduce the crash inside, so I can investigate?

rjarry · 2024-02-20T22:34:07Z

Hi there,

I can also reproduce the issue with read_marker.py and soju.py loaded, in that order. For some reason, loading soju.py first does not trigger the issue every time.

Reproducer:

run weechat -s to disable autoloading of any script
/script load read_marker.py
/script load soju.py
/quit

Here is some more debug info if that helps:

Python 3.12.1 (main, Dec 18 2023, 00:00:00) [GCC 13.2.1 20231205 (Red Hat 13.2.1-6)] on linux

======= WeeChat backtrace =======
(written by WeeChat 4.2.1, compiled on Feb 14 2024 23:44:18)
001  /home/rjarry/upstream/weechat/src/core/wee-backtrace.c:167 [function weechat_backtrace]
002  /home/rjarry/upstream/weechat/src/core/wee-debug.c:192 [function debug_sigsegv_cb]
003  ??:? [function __restore_rt]
004  ??:? [function _PyObject_FastCallDictTstate]
005  ??:? [function PyObject_Free]
006  ??:? [function _PyModule_ClearDict]
007  ??:? [function PyGC_Collect]
008  ??:? [function Py_EndInterpreter]
009  /home/rjarry/upstream/weechat/src/plugins/python/weechat-python.c:978 [function weechat_python_unload]
010  /home/rjarry/upstream/weechat/src/plugins/python/weechat-python.c:1022 [function weechat_python_unload_all]
011  /home/rjarry/upstream/weechat/src/plugins/plugin-script.c:1791 [function plugin_script_end]
012  /home/rjarry/upstream/weechat/src/plugins/python/weechat-python.c:1569 [function weechat_plugin_end]
013  /home/rjarry/upstream/weechat/src/plugins/plugin.c:1259 [function plugin_unload]
014  /home/rjarry/upstream/weechat/src/plugins/plugin.c:1306 [function plugin_unload_all]
015  /home/rjarry/upstream/weechat/src/plugins/plugin.c:1431 [function plugin_end]
016  /home/rjarry/upstream/weechat/src/core/weechat.c:710 [function weechat_end]
017  /home/rjarry/upstream/weechat/src/gui/curses/normal/main.c:47 [function main]
018  ??:? [function __libc_start_call_main]
019  :? [function __libc_start_main_alias_2]
020  ??:? [function _start]
======= End of  backtrace =======

(gdb) thread apply all bt full

Thread 1 (Thread 0x7f4e332f0a80 (LWP 171986)):
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
        tid = <optimized out>
        ret = 0
        pd = <optimized out>
        old_mask = {
          __val = {[0] = 140730321364448}
        }
        ret = <optimized out>
#1  0x00007f4e33aca8a3 in __pthread_kill_internal (signo=6, threadid=<optimized out>) at pthread_kill.c:78
No locals.
#2  0x00007f4e33a788ee in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
        ret = <optimized out>
#3  0x00007f4e33a608ff in __GI_abort () at abort.c:79
        save_stage = 1
        act = {
          __sigaction_handler = {
            sa_handler = 0x20,
            sa_sigaction = 0x20
          },
          sa_mask = {
            __val = {[0] = 139973852474048, [1] = 416, [2] = 14057664, [3] = 140730321364592, [4] = 139973851178954, [5] = 2, [6] = 18446744073709551472, [7] = 2, [8] = 14057248, [9] = 139973824960864, [10] = 18446744073709551472, [11] = 2, [12] = 12498224, [13] = 140730321364672, [14] = 139973851190238, [15] = 140730321364656}
          },
          sa_flags = 870771879,
          sa_restorer = 0x7f4e318eb790
        }
#4  0x0000000000406e6f in weechat_shutdown (return_code=1, crash=1) at /home/rjarry/upstream/weechat/src/core/weechat.c:600
No locals.
#5  0x00000000004355f7 in debug_sigsegv_cb () at /home/rjarry/upstream/weechat/src/core/wee-debug.c:192
No locals.
#6  <signal handler called>
No locals.
#7  0x00007f4e31df9a8d in _PyGCHead_SET_NEXT (next=0x7f4e318eb730, gc=0x7f4e3225f0c8) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Include/internal/pycore_gc.h:63
No locals.
#8  _PyObject_GC_UNTRACK (op=0x7f4e318eb790) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Include/internal/pycore_object.h:246
        gc = 0x7f4e318eb780
        prev = 0x7f4e3225f0c8
        next = 0x7f4e318eb730
        gc = <optimized out>
        prev = <optimized out>
        next = <optimized out>
#9  PyObject_GC_UnTrack (op_raw=0x7f4e318eb790) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Modules/gcmodule.c:2242
        op = 0x7f4e318eb790
        op = <optimized out>
#10 meth_dealloc (m=0x7f4e318eb790) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Objects/methodobject.c:162
No locals.
#11 0x00007f4e31dec157 in _Py_Dealloc (op=0x7f4e318eb790) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Objects/object.c:2625
        type = <optimized out>
        dealloc = <optimized out>
#12 Py_DECREF (op=0x7f4e318eb790) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Include/object.h:706
No locals.
#13 Py_XDECREF (op=0x7f4e318eb790) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Include/object.h:799
No locals.
#14 insertdict (interp=<optimized out>, mp=0x7f4e30bc7b00, key=0x7f4e32172740 <const_str_register>, hash=<optimized out>, value=0x7f4e321d5960 <_Py_NoneStruct>) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Objects/dictobject.c:1319
        old_value = 0x7f4e318eb790
        ix = <optimized out>
#15 0x00007f4e31e4fe60 in PyDict_SetItem (value=0x7f4e321d5960 <_Py_NoneStruct>, key=0x7f4e32172740 <const_str_register>, op=0x7f4e30bc7b00) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Objects/dictobject.c:1883
No locals.
#16 _PyModule_ClearDict (d=0x7f4e30bc7b00) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Objects/moduleobject.c:656
        pos = 6
        key = 0x7f4e32172740 <const_str_register>
        value = 0x7f4e318eb790
        verbose = <optimized out>
#17 0x00007f4e31ebde94 in finalize_modules_clear_weaklist (verbose=0, weaklist=0x7f4e30d294c0, interp=0x230a8e0) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Python/pylifecycle.c:1526
        tup = <optimized out>
        name = 0x7f4e30bc94a0
        mod = 0x7f4e30bd8540
        dict = <optimized out>
        i = 70
#18 finalize_modules (tstate=tstate@entry=0x2368200) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Python/pylifecycle.c:1609
        interp = <optimized out>
        modules = <optimized out>
        verbose = 0
        weaklist = 0x7f4e30d294c0
#19 0x00007f4e31ecb494 in Py_EndInterpreter (tstate=0x2368200) at /usr/src/debug/python3.12-3.12.1-2.fc39.x86_64/Python/pylifecycle.c:2199
        interp = 0x230a8e0
        __func__ = "Py_EndInterpreter"
#20 0x00007f4e323fc007 in weechat_python_unload (script=0x2218e10) at /home/rjarry/upstream/weechat/src/plugins/python/weechat-python.c:975
        rc = 0x270e6d0
        interpreter = 0x2368200
        filename = 0x5d074a0 "/home/rjarry/.local/share/weechat/python/autoload/soju.py"
#21 0x00007f4e323fc1c7 in weechat_python_unload_all () at /home/rjarry/upstream/weechat/src/plugins/python/weechat-python.c:1024
No locals.
#22 0x00007f4e3242c8a6 in plugin_script_end (weechat_plugin=0xe592a0, plugin_data=0x7f4e3243a140 <python_data>) at /home/rjarry/upstream/weechat/src/plugins/plugin-script.c:1790
        scripts_loaded = 1
#23 0x00007f4e323fd76d in weechat_plugin_end (plugin=0xe592a0) at /home/rjarry/upstream/weechat/src/plugins/python/weechat-python.c:1568
No locals.
#24 0x00000000004c3fb5 in plugin_unload (plugin=0xe592a0) at /home/rjarry/upstream/weechat/src/plugins/plugin.c:1256
        end_func = 0x7f4e323fd70c <weechat_plugin_end>
        name = 0x1b45be0 "python"
#25 0x00000000004c411c in plugin_unload_all () at /home/rjarry/upstream/weechat/src/plugins/plugin.c:1308
        plugins_loaded = 1
#26 0x00000000004c4475 in plugin_end () at /home/rjarry/upstream/weechat/src/plugins/plugin.c:1428
No locals.
#27 0x00000000004071a9 in weechat_end (gui_end_cb=0x4bb8df <gui_main_end>) at /home/rjarry/upstream/weechat/src/core/weechat.c:709
No locals.
#28 0x0000000000406129 in main (argc=1, argv=0x7ffe54d071d8) at /home/rjarry/upstream/weechat/src/gui/curses/normal/main.c:45
No locals.

trygveaa · 2024-02-20T22:37:01Z

I bisected this issue to this commit in cpython: python/cpython@de64e75

trygveaa · 2024-03-08T19:23:49Z

I posted an issue to CPython for this: python/cpython#116510

I also noticed that it's fixed in version v3.13.0a4.

Python 3.12 has a bug where it crashes when you unload all the interpreters unless you make sure to unload the first interpreter you loaded last. For some reason, loading the eval interpreter before any scripts also seems to prevent the issue, even if the eval interpreter is unloaded before the other interpreters. So this just evals an empty string at the end of initing the Python plugin if the Python version is 3.12, to make sure the eval interpreter is loaded first. Fixes weechat#2046

belkka · 2024-06-17T16:23:18Z

Guys in IRC helped me to compile weechat's python plugin linked to python3.13. I have:

weechat from Archlinux repository (with python plugin linked to python3.12)
python313 from AUR (in parallel with python 3.12 from the core repo)
weechat python plugin (python.so) linked to python3.13 living in my ~/.local/share/weechat/plugins/, which overrides system-wide plugin.

Here is a guide: https://gist.github.com/belkka/4dc42664fe383983c5a5d9d99da00952

Thanks to trygveaa and others at libera.chat for babysitting me. (do not confuse with trygveaa at github — they could be an impostor)

flashcode · 2024-06-17T16:55:07Z

@belkka: FYI, @trygveaa is not an imposter.

Python 3.12 has a bug where it crashes when you unload all the interpreters unless you make sure to unload the first interpreter you loaded last. For some reason, loading the eval interpreter before any scripts also seems to prevent the issue, even if the eval interpreter is unloaded before the other interpreters. So this just evals an empty string at the end of initing the Python plugin if the Python version is 3.12, to make sure the eval interpreter is loaded first. Fixes #2046

…2046, issue #2126)

…2046, issue #2126) This should definitely fix the crash with Python 3.12, even when scripts are auto-loaded (the previous fix was working only when the scripts are loaded manually).

…2046, issue #2126)

…2046, issue #2126) This should definitely fix the crash with Python 3.12, even when scripts are auto-loaded (the previous fix was working only when the scripts are loaded manually).

belkka · 2024-06-26T20:44:52Z

So the issue is fixed even in python 3.12 now? 😮

@flashcode

are you impostor's buddy?
how do you usually verify that some github account and some libera.chat account are controlled by the same person? :)

flashcode · 2024-06-26T20:57:37Z

I improved the workaround developed by @trygveaa, so now it should not crash even with auto-loaded scripts.

@belkka: there are no imposters here, if you don't trust us, please stop commenting.

belkka · 2024-06-27T08:28:22Z

I confirm that weechat doesn't crash on exit anymore! Thanks! For that I've upgraded to weechat 4.3.3, removed ~/.local/share/weechat/plugins.so, uninstalled python3.13, checked that I do have multiple python scripts installed

@flashcode

(1) no, and this is actually rude. (2) the first question was a joke (which you decided to respond to), but the second question was an initiation of inter-person trust-establishment protocol. (3) I was not asking for this and have nothing to do with this information (even if I could verify the claim). I just pointed out that same-name identities on different hosts can be controlled by different people. I have no idea why you felt like it's important to start and continue this conversation. Feel free to stop as soon as you feel there is nothing valuable to tell; I'm not spamming with follow-ups demanding to answer my questions.

Please, don't teach people to trust verifiable claims WITHOUT verification. Children could read github.

Also, to clarify my wording: I chose the word "impostor" to add a humorous connotation influenced by a community of one popular game. While doing so, I was still only referring to the original meaning of the word (impersonation), not to any of the in-game activities (sabotage/killing). In particular, I didn't mean to say that any of github users could be "saboteurs". I thought I've made it clear from the context by saying "...do not confuse A with B..."

nascheme · 2024-06-29T22:10:41Z

@flashcode

I spent some time investigating today and came up with a different work-around. See: python/cpython#116510 (comment)

How does your workaround work, do you think?

laemeiqu added the bug Unexpected problem or unintended behavior label Nov 21, 2023

laemeiqu mentioned this issue Nov 21, 2023

weechat crashes on exit when both title.py and autosort.py are loaded void-linux/void-packages#47336

Closed

flashcode added the waiting info Waiting for info from author of issue label Nov 30, 2023

flashcode self-assigned this Nov 30, 2023

trygveaa mentioned this issue Feb 20, 2024

Crash on weechat exit wee-slack/wee-slack#922

Closed

trygveaa mentioned this issue Mar 8, 2024

CPython 3.12 embedded in WeeChat causes segfault on subsequent calls to Py_EndInterpreter python/cpython#116510

Open

trygveaa mentioned this issue Jun 3, 2024

python: Segfault on exit with certain scripts #2125

Closed

trygveaa mentioned this issue Jun 3, 2024

python: add workaround for crash on unload with Python 3.12 #2126

Merged

flashcode closed this as completed in #2126 Jun 23, 2024

flashcode removed the waiting info Waiting for info from author of issue label Jun 23, 2024

flashcode added a commit that referenced this issue Jun 23, 2024

core: update ChangeLog (issue #2046, issue #2126)

7cab57f

flashcode added a commit that referenced this issue Jun 23, 2024

core: update ChangeLog (issue #2046, issue #2126)

1de31fc

flashcode added a commit that referenced this issue Jun 26, 2024

scripts: fix reset of "quiet" status in case of nested calls (issue #…

3d3d8f2

…2046, issue #2126)

flashcode added a commit that referenced this issue Jun 26, 2024

scripts: fix reset of "quiet" status in case of nested calls (issue #…

e5725a3

…2046, issue #2126)

flashcode mentioned this issue Jul 3, 2024

Crash when exiting #2142

Closed

flashcode changed the title ~~weechat crashes on exit when both title.py and autosort.py are loaded (voidlinux)~~ WeeChat crashes on exit when both title.py and autosort.py are loaded with Python 3.12 (voidlinux) Jul 3, 2024

flashcode added this to the 4.4.0 milestone Jul 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WeeChat crashes on exit when both title.py and autosort.py are loaded with Python 3.12 (voidlinux) #2046

WeeChat crashes on exit when both title.py and autosort.py are loaded with Python 3.12 (voidlinux) #2046

laemeiqu commented Nov 21, 2023

laemeiqu commented Nov 21, 2023

flashcode commented Nov 22, 2023

laemeiqu commented Nov 23, 2023

flashcode commented Nov 30, 2023

rjarry commented Feb 20, 2024

trygveaa commented Feb 20, 2024

trygveaa commented Mar 8, 2024

belkka commented Jun 17, 2024

flashcode commented Jun 17, 2024

belkka commented Jun 26, 2024

flashcode commented Jun 26, 2024

belkka commented Jun 27, 2024

nascheme commented Jun 29, 2024

WeeChat crashes on exit when both title.py and autosort.py are loaded with Python 3.12 (voidlinux) #2046

WeeChat crashes on exit when both title.py and autosort.py are loaded with Python 3.12 (voidlinux) #2046

Comments

laemeiqu commented Nov 21, 2023

Bug summary

Steps to reproduce

Current behavior

Expected behavior

Suggested solutions

Additional information

laemeiqu commented Nov 21, 2023

flashcode commented Nov 22, 2023

laemeiqu commented Nov 23, 2023

flashcode commented Nov 30, 2023

rjarry commented Feb 20, 2024

trygveaa commented Feb 20, 2024

trygveaa commented Mar 8, 2024

belkka commented Jun 17, 2024

flashcode commented Jun 17, 2024

belkka commented Jun 26, 2024

flashcode commented Jun 26, 2024

belkka commented Jun 27, 2024

nascheme commented Jun 29, 2024