Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server echoes of /me are not properly tagged with irc_tag_ annotations #2074

Closed
ToxicFrog opened this issue Feb 13, 2024 · 0 comments
Closed
Assignees
Labels
bug Unexpected problem or unintended behavior
Milestone

Comments

@ToxicFrog
Copy link

Describe the bug

When connected to a network that supports server-side echoing, the server may add message tags to its echoes of your message, e.g. time to denote the message timestamp or account to denote a stable-across-nick-changes account name. These show up in weechat's line-tagging system as, e.g., irc_tag_time=2024-02-12T16:43:35.079Z.

When using /me, however, these tags are not added to weechat's line tags. /me messages from other users are properly tagged, but your own are not.

Steps to reproduce

  1. Connect to a server that supports echoing, like libera
  2. Send a normal message
  3. Send a message with /me
  4. Get someone else to send both kinds of messages
  5. /debug tags

Current behavior

All of the messages except the /me you sent will have proper irc_tag_ tags (for libera, this usually means irc_tag_account and irc_tag_time; other networks may have different ones). The /me you sent will have the rest of its tags like irc_action and self_msg, but not the irc_tag_ tags. Looking at irc_raw will confirm that the server echo had the correct tags, they just weren't applied.

Expected behavior

All messages have the appropriate irc_tag_ tags.

Suggested solutions

No response

Additional information

No response

WeeChat version

4.1.1

What OS are you using?

NixOS

On which terminal are you running WeeChat?

No response

Which terminal multiplexer are you using?

No response

@ToxicFrog ToxicFrog added the bug Unexpected problem or unintended behavior label Feb 13, 2024
flashcode added a commit that referenced this issue Feb 16, 2024
@flashcode flashcode self-assigned this Feb 16, 2024
@flashcode flashcode added this to the 4.3.0 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

2 participants