Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/input search_stop always scrolls to the bottom #2093

Closed
trygveaa opened this issue Mar 13, 2024 · 0 comments · Fixed by #2094
Closed

/input search_stop always scrolls to the bottom #2093

trygveaa opened this issue Mar 13, 2024 · 0 comments · Fixed by #2094
Assignees
@flashcode
Labels
bug Unexpected problem or unintended behavior
Milestone
4.3.0

Comments

@trygveaa
Copy link
Contributor

Describe the bug

When you exit a search with /input search_stop it always scrolls to the bottom, even if the buffer was scrolled before the search was started.

Steps to reproduce

  1. Scroll up in a buffer
  2. Start a search
  3. Type a query (optional)
  4. Exit the search with ctrl+q

Current behavior

The buffer scrolls to the bottom.

Expected behavior

The buffer should scroll to where it was before I started the search.

Suggested solutions

No response

Additional information

This is a regression with commit b83b428. Before that it worked as expected.

WeeChat version

4.3.0-dev (git: v4.2.0-140-gf76d23601)

What OS are you using?

Arch Linux

On which terminal are you running WeeChat?

No response

Which terminal multiplexer are you using?

No response
@trygveaa trygveaa added the bug Unexpected problem or unintended behavior label Mar 13, 2024
trygveaa added a commit to trygveaa/weechat that referenced this issue Mar 13, 2024
@trygveaa
core: make search_stop scroll to search start position
edc566f 
When you run /input search_stop it should scroll to the scroll position
the buffer was at before starting the search, rather than to the bottom
of the buffer.

Fixes a regression introduced in commit b83b428

Fixes weechat#2093
@trygveaa trygveaa mentioned this issue Mar 13, 2024
Merged
flashcode pushed a commit that referenced this issue Mar 13, 2024
@trygveaa @flashcode
core: make search_stop scroll to search start position
811390e 
When you run /input search_stop it should scroll to the scroll position
the buffer was at before starting the search, rather than to the bottom
of the buffer.

Fixes a regression introduced in commit b83b428

Fixes #2093
@flashcode flashcode added this to the 4.3.0 milestone Mar 13, 2024
@flashcode flashcode self-assigned this Mar 13, 2024
flashcode added a commit that referenced this issue Mar 13, 2024
@flashcode
core: update ChangeLog (issue #2093)
fe01faa
flashcode pushed a commit that referenced this issue Mar 13, 2024
@trygveaa @flashcode
core: make search_stop scroll to search start position (issue #2093)
fe14ced 
When you run /input search_stop it should scroll to the scroll position
the buffer was at before starting the search, rather than to the bottom
of the buffer.

Fixes a regression introduced in commit b83b428

Fixes #2093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flashcode flashcode

Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

core: make search_stop scroll to search start position trygveaa/weechat
2 participants
@trygveaa @flashcode